Enable health endpoint on the kbs pods - #172
Merged
lmilleri merged 1 commit intoAug 20, 2026
Merged
Conversation
Signed-off-by: Neeraj Krishna Gopalakrishna <ngopalak@redhat.com>
ngopalak-redhat
force-pushed
the
ngopalak/health-endpoint
branch
from
August 18, 2026 11:16
798cd2d to
8c6cff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying out the trustee, it was hard to find out if the trustee really came up. I used curl on the health endpoint, hence I thought its good to add that as a probe.
The /healthz endpoint was added to KBS in trustee#1398 (merged 2026-06-02), which returns HTTP 200 on the same port 8080 that serves the KBS API. However, the trustee-operator never wired up Kubernetes probes to use it. Without probes, Kubernetes has no way to detect if the KBS process hangs or fails to serve requests.
Pods stay in Running state even when unhealthy, and the deployment reports Available the moment the container starts, before KBS is actually ready to accept connections. This change adds readiness and liveness probes to the KBS container using HTTPGet against /healthz on port 8080, with the scheme (HTTP or HTTPS) auto-detected from the existing isHttpsConfigPresent() helper. This ensures traffic is only routed to pods that are genuinely serving, and hung processes are automatically restarted.