Skip to content

docs: explain how to find the release ECP #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BohdanMar wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −4
Open

docs: explain how to find the release ECP #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e225ee9
docs: explain how to find the release ECP
BohdanMar Sep 2, 2026
055ec45
docs: address review feedback — grep releasePlanAdmission, use rpa-name
BohdanMar Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions modules/ROOT/pages/early-policy-violations.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,24 @@ and another matching your release policy.
=== Step 1: Find your release policy configuration

Your release policy is defined in the `ReleasePlanAdmission` in your managed
namespace. Ask your release engineering or SRE team for the
`EnterpriseContractPolicy` (ECP) name or configuration used in your release
pipeline. The value is typically in the format `namespace/name`, for example
`rhtap-releng-tenant/registry-rhtap-contract`.
namespace. To find it, look up your `ReleasePlan` and find the associated
`ReleasePlanAdmission` name:

[,shell,subs="+quotes"]

@fullsend-ai-review fullsend-ai-review Bot Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] logic-error

Step 1 instructs the user to find the ReleasePlanAdmission (RPA) name and prepend the managed namespace to form a reference like rhtap-releng-tenant/<rpa-name>. However, Step 2's YAML template uses the placeholder <managed-namespace>/<ecp-name>, and the surrounding text says to 'set POLICY_CONFIGURATION to the ECP used by your release pipeline,' referencing an EnterpriseContractPolicy CR. This creates an inconsistency: Step 1 produces an RPA reference, but Step 2 asks for an ECP reference. If POLICY_CONFIGURATION accepts RPA references directly, the Step 2 placeholder and description should be updated to match Step 1's output. If it only accepts ECP references, Step 1 needs an additional command to extract the ECP name from within the RPA.

Suggested fix: Align the two steps. Either (a) update the Step 2 placeholder from <managed-namespace>/<ecp-name> to <managed-namespace>/<rpa-name> and adjust the explanatory text to clarify that POLICY_CONFIGURATION accepts RPA references, or (b) add a command in Step 1 that extracts the ECP reference from the RPA (e.g., oc get releaseplanadmission <rpa-name> -n <managed-namespace> -o yaml | yq .spec.policy).

----
$ oc get releaseplan __<releaseplan-name>__ -o yaml | yq .metadata.labels | grep releasePlanAdmission
----

The output includes a label like
`release.appstudio.openshift.io/releasePlanAdmission: <rpa-name>`. Prepend the
managed namespace to get the full reference, for example
`rhtap-releng-tenant/<rpa-name>`.

You can also find this in the `konflux-release-data` repository by browsing
your tenant's `ReleasePlan` YAML files under
`tenants-config/auto-generated/cluster/<cluster>/tenants/<tenant>/`.

Ask your release engineering or SRE team if you have trouble finding it.

=== Step 2: Create a non-blocking integration test

Expand Down
Loading