Add equal spacing outside of main stack#7
Open
Obumbravit wants to merge 1 commit intoconorthedev:masterfrom
Open
Add equal spacing outside of main stack#7Obumbravit wants to merge 1 commit intoconorthedev:masterfrom
Obumbravit wants to merge 1 commit intoconorthedev:masterfrom
Conversation
conorthedev
reviewed
May 11, 2021
| - (void)layoutSubviews { | ||
| [super layoutSubviews]; | ||
|
|
||
| if (self.containerStackView.spacing != (self.bounds.size.width - (60 * [self.options count])) / ([self.options count] + 1)) self.containerStackView.spacing = (self.bounds.size.width - (60 * [self.options count])) / ([self.options count] + 1); |
Owner
There was a problem hiding this comment.
Not a fan of using layoutSubviews for stuff like this. Is there a better solution that you could do?
conorthedev
reviewed
May 11, 2021
| Package: me.conorthedev.libappearancecell | ||
| Name: libappearancecell | ||
| Version: 1.0.2 | ||
| Version: 1.0.3 |
Owner
There was a problem hiding this comment.
Don't increment the version please :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More reminiscent of iOS 13's appearance selector spacing. Also allows for adding more cells before running into issues, as a product of automatically calculated spacing.