Skip to content

More code cleanup #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
conradwt merged 3 commits into from
Apr 26, 2026
Merged

More code cleanup #310

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b3055f
Code cleanup.
conradwt Apr 26, 2026
5581930
More code cleanup.
conradwt Apr 26, 2026
3b4cfee
Merge branch 'main' into more-code-cleanup
conradwt Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/call-docker-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,23 @@ jobs:
uses: conradwt/docker-build-workflow/.github/workflows/reusable-docker-build-native.yaml@main

# set permissions here to be equal or greater than what's required in the Reusable Workflow
# Permisions set here for the GITHUB_TOKEN are then passed to the Reusable Workflow
# Permissions set here for the GITHUB_TOKEN are then passed to the Reusable Workflow
# Calling permissions must be equal to or greater than these reusable permissions for it to work
# https://docs.github.com/en/actions/using-workflows/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow
permissions:
contents: read
packages: write # needed to push docker image to ghcr.io
pull-requests: write # needed to create and update comments in PRs
# secrets:

# secrets:

# Only needed if with:dockerhub-enable is true below
# https://hub.docker.com/settings/security
# dockerhub-username: ${{ secrets.DOCKERHUB_USERNAME }}
# dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }}

# with:
with:

# NOTE: there are lots of input options for this reusable workflow
# read the comments in the inputs area of the reusable workflow for more info
# https://github.com/BretFisher/docker-build-workflow/blob/main/.github/workflows/reusable-docker-build.yaml
Expand All @@ -72,7 +74,7 @@ jobs:
# target:

# platforms are *native GitHub Runners by default, so only amd64 and/or arm64 are supported, and must be in JSON syntax.
# for more platform build options, there's a "QEMU" reusable workflow option in this repo's .github/workflows folder
# platforms: '["linux/amd64", "linux/arm64"]'
# for more platform build options, there's a "QEMU" reusable workflow ption in this repo's .github/workflows folder
platforms: '["linux/amd64", "linux/arm64"]'

# comment-enable: true
Loading