Add support for runc's --pidfd-socket - #115
Merged
Merged
Conversation
runc can send a pidfd for the process it creates over a unix socket. A pidfd lets the caller signal or wait on that process without racing against the pid reuse that a pid from --pid-file is subject to. Adds PidfdSocket to CreateOpts and ExecOpts, covering create, run and exec, plus the socket constructors and ReceivePidfd to accept the descriptor. runc restore has no such flag, so RestoreOpts is unchanged. The socket plumbing shared with the console socket moves to socket.go, leaving console.go with only the console-specific parts. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Member
|
Thanks for working on this! - containerd/containerd#9175 |
fuweid
reviewed
Aug 21, 2026
fuweid
approved these changes
Aug 21, 2026
mxpv
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runc can send a pidfd for the process it creates over a unix socket. A
pidfd lets the caller signal or wait on that process without racing
against the pid reuse that a pid from --pid-file is subject to.
Adds PidfdSocket to CreateOpts and ExecOpts, covering create, run and
exec, plus the socket constructors and ReceivePidfd to accept the
descriptor. runc restore has no such flag, so RestoreOpts is unchanged.
The socket plumbing shared with the console socket moves to socket.go,
leaving console.go with only the console-specific parts.
Additionally adds a minor hardening to not leak fd's when receiving them in error cases.