deprecate ErrParseRuncVersion - #118
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates the exported ErrParseRuncVersion sentinel (kept for potential downstream checks) and simplifies the internal version parsing logic by removing an unused error return, with corresponding test refactoring.
Changes:
- Mark
ErrParseRuncVersionas deprecated. - Change
parseVersionto returnVersiononly (no error) and updateRunc.Version()accordingly. - Refactor
TestParseVersioninto a table-driven test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| runc.go | Deprecates ErrParseRuncVersion and simplifies parseVersion/Version() return flow. |
| runc_test.go | Updates tests to table-driven form and matches new parseVersion signature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This error was added in 6a4f927, but no longer used since e32098a (before v1.0.0). Deprecate it, in case there's consumers checking for this error. Also remove the error-return from parseVersion, which was never used, and rewrite the test to use a test-table to make it a bit more DRY. updates 6a4f927 updates e32098a Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_ErrParseRuncVersion
branch
from
August 22, 2026 15:53
6da3424 to
e039ef4
Compare
AkihiroSuda
approved these changes
Aug 22, 2026
mxpv
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
This error was added in 6a4f927, but no longer used since e32098a (before v1.0.0).
Deprecate it, in case there's consumers checking for this error. Also remove the error-return from parseVersion, which was never used, and rewrite the test to use a test-table to make it a bit more DRY.
updates 6a4f927
updates e32098a