ci: update actions, golangci-lint, and test against oldest (go.mod), oldstable, and stable - #120
Merged
Merged
Conversation
thaJeztah
commented
Aug 22, 2026
Member
- fix linting
- ci: update actions and golangci-lint
- ci: apply zizmor fixes, ping actions by sha
- ci: remove custom working-directories and GOPATH
- ci: test against oldest (go.mod), oldstable, and stable Go versions
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s CI and linting posture while making small code/test tweaks to satisfy the updated static analysis configuration (notably gosec) and improve documentation.
Changes:
- Updates golangci-lint configuration to v2 format, enabling additional linters (e.g., gosec, govet) and extending lint timeout.
- Hardens GitHub Actions workflow (pinned action SHAs, explicit permissions) and expands test matrix to cover minimum (go.mod), oldstable, and stable Go versions.
- Adds/adjusts inline suppression comments and minor code/test cleanups to align with the new linting expectations.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
socket.go |
Adds gosec suppression comments and makes cleanup calls explicitly best-effort. |
runc.go |
Adds package-level documentation for the public runc package. |
runc_test.go |
Refines the parallel/race-oriented test to better synchronize goroutines and asserts Version parsing doesn’t error on empty output. |
monitor.go |
Marks an unused parameter explicitly unused to satisfy linters. |
command_other.go |
Adds gosec suppression for intentional exec.CommandContext usage. |
command_linux.go |
Adds gosec suppression for intentional exec.CommandContext usage (Linux variant). |
.golangci.yml |
Migrates to golangci-lint v2 config format; enables gosec/govet and introduces formatters. |
.github/workflows/ci.yml |
Pins actions by SHA, scopes permissions, updates linter invocation, and expands Go test matrix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+21
to
+24
| formatters: | ||
| enable: | ||
| - gofmt | ||
| - goimports |
Member
Author
There was a problem hiding this comment.
You're hallucinating; goimports and gofmpt are a formatter in Golangci-lint v2; both formatters and linters will fail CI if not done correctly.
AkihiroSuda
approved these changes
Aug 22, 2026
mxpv
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.