feat: add support for container cp with tarballs #4704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sondavidb
commented
Jan 16, 2026
| - `nerdctl cp [OPTIONS] CONTAINER:SRC_PATH DEST_PATH|-` | ||
| - `nerdctl cp [OPTIONS] SRC_PATH|- CONTAINER:DEST_PATH` | ||
|
|
||
| Using `-` as the `SRC_PATH` streams the contents of `STDIN` as a tar archive. The command extracts the content of the tar to the `DEST_PATH` in container's filesystem. In this case, `DEST_PATH` must specify a directory. Using `-` as the `DEST_PATH` streams the contents of the resource as a tar archive to `STDOUT`. |
Contributor
Author
There was a problem hiding this comment.
FYI, copied this exact wording from https://docs.docker.com/reference/cli/docker/container/cp/#corner-cases. LMK if this is a problem in any way.
Contributor
Author
|
Will get to adding testing tomorrow. Having some trouble adding tests to the existing testing suite for now. |
Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
add-container-cp-tarballs
branch
from
5bd5c65 to
91f3775
Compare
Contributor
Author
|
I was very optimistic about the testing suite, stuffing the test cases in there took a lot of effort. This suite could certainly split up some functions (the amount of if statements in here is hard to keep track of, to say the least...) In any case, tests passed locally so hoping this should be good to go 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4691
This PR should allow support for the following in
container cp:-in src to allow streaming the contents of a tarball into a container.-in dst to allow streaming the contents of a container into a tarball that is written to stdout