Implementation of WithPluginRegistrationTimeout option#292
Open
egorikas wants to merge 1 commit into
Open
Conversation
Signed-off-by: egorikas <egorgrishechko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a busy Kubernetes node, NRI plugin startup races against the runtime and loses. The plugin-side
DefaultRegistrationTimeoutis hardcoded at 5s with no override, while the runtime-sideplugin_registration_timeoutis operator-configurable (we set it to 10s in Uber env).When the plugin's 5s timer fires first. It gives up and closes its end of the ttrpc connection. Then the runtime finally accepts the connection. It reads the buffered register frame, which succeeds against stale state. The next call, Configure, returns
ttrpc.ErrClosedright away because the plugin's side is already gone. The user seesfailed to register with NRI/Runtime: ttrpc: closed. That hides the real cause: registration timed out before the runtime got to it.The error made a lot of confusion for me. And in this PR I mirror the internal patch we did.