Skip to content

Support returning ip addresses with RunPodSandbox#295

Open
MikeZappa87 wants to merge 2 commits into
containerd:mainfrom
MikeZappa87:mzappa/runpodip
Open

Support returning ip addresses with RunPodSandbox#295
MikeZappa87 wants to merge 2 commits into
containerd:mainfrom
MikeZappa87:mzappa/runpodip

Conversation

@MikeZappa87
Copy link
Copy Markdown
Member

@MikeZappa87 MikeZappa87 commented May 12, 2026

This PR came out of a discussion with @mikebrow regarding if an alternative exists to adding PodSandboxStatus to NRI. He proposed adding ip addresses to the RunPodSandboxResponse.

#267

@MikeZappa87 MikeZappa87 marked this pull request as ready for review May 12, 2026 23:21
Signed-off-by: Michael Zappa <michael.zappa@gmail.com>
Comment thread pkg/api/api.proto

message RunPodSandboxResponse{}
message RunPodSandboxResponse{
repeated string ips = 1;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add anything else? Interfaces? Routes?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an envelope msg that sets the stage for additional fields. Right now containerd has fields for the ip, additional ips but the fields you mention are part of the CNI result string. We could add them.

Copy link
Copy Markdown
Member

@mikebrow mikebrow May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nod we can add the info map record for verbose status reporting later on.. with a follow-up

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current we have a PodSandboxNetwork message which could provide typed fields instead? That might be preferable as we evolve the networking capabilities in NRI.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nod i presumed either map[key]=any json string... or typed fields if there's agreement on the definition

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do both. The same convention in cri-api helps with extensibility and luckily for networking, a lot of fields have been well defined for some time. I think once this is merged, we can look to adding those fields.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err ^ best case

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like our pattern of supporting annotation meta for optional/experimental projects, and typed fields where we have solid ground

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for that as well. Perhaps we can just go ahead and add

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeated string ips = 10;
We 'could' just return PodSandbox type as well and extend it with new fields?

Signed-off-by: Michael Zappa <michael.zappa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants