[DO NOT REVIEW] overlay: add EBUSY workaround for rename #620
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unix.Rename() fails with EBUSY while replacing the merged directory mountpoint, fall back to removing both directories and creating a fresh mountpoint directory. This could happen if the mount leaked in some mount namespace. This addresses cases where the target mountpoint is busy and cannot be atomically replaced, providing a workaround for the rename approach introduced in commit d9ec6b5. It reintroduces in part the issue fixed by that commit but the window of opportunity is much smaller, as it needs #skip_mount_home and the mount leaked via a recursive mount from the host into another container. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Member
Author
|
under investigation for CRI-O. Do not review yet. |
giuseppe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unix.Rename() fails with EBUSY while replacing the merged directory mountpoint, fall back to removing both directories and creating a fresh mountpoint directory. This could happen if the mount leaked in some mount namespace.
This addresses cases where the target mountpoint is busy and cannot be atomically replaced, providing a workaround for the rename approach introduced in commit d9ec6b5.
It reintroduces in part the issue fixed by that commit but the window of opportunity is much smaller, as it needs #skip_mount_home and the mount leaked via a recursive mount from the host into another container.