Update rust edition#686
Open
jakecorrenti wants to merge 14 commits into
Open
Conversation
jakecorrenti
force-pushed
the
update-rust-edition
branch
from
dacb47c to
48193c8
Compare
jakecorrenti
force-pushed
the
update-rust-edition
branch
3 times, most recently
from
b3c9aca to
25755ce
Compare
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
- Add `unsafe` to all 79 extern "C" blocks (78 in bindings.rs, 1 in lib.rs) - Remove redundant `ref` binding modifier in match arm (2024 edition error) Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
The virgl_renderer feature requires system libraries not available during the initial migration, so these code paths were not reached by cargo fix. Also fix two collapsible_if clippy warnings in virtio/gpu that only surface when compiling krun-devices with the gpu feature. Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
jakecorrenti
force-pushed
the
update-rust-edition
branch
from
25755ce to
244a733
Compare
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
- Bump edition from 2021 to 2024 in Cargo.toml
- Wrap #[no_mangle] with #[unsafe(no_mangle)] (84 occurrences)
- Add unsafe {} blocks inside unsafe fn bodies (unsafe-op-in-unsafe-fn)
- Collapse nested if-let blocks flagged by clippy::collapsible_if
Assisted-by: Claude Code: claude-sonnet-4-6
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Add [workspace] to mark it as a standalone crate (not a workspace member), bump edition to 2024 and rust-version to 1.85.0. No source changes were required by cargo fix. Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Assisted-by: Claude Code: claude-sonnet-4-6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
jakecorrenti
force-pushed
the
update-rust-edition
branch
from
244a733 to
99199a1
Compare
jakecorrenti
requested review from
MatiasVara,
dorindabassey,
mtjhrc,
slp and
tylerfanelli
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update from the 2021 edition to the 2024 edition.