Skip to content

golang,golang-ci-lint: bump versions, fix linting errors. #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klihub merged 4 commits into from
Apr 20, 2026
Merged

golang,golang-ci-lint: bump versions, fix linting errors. #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a7812e
Makefile: update/fix ginkgo coverprofile command line option.
klihub Apr 14, 2026
a0fd7e3
go.mod,.github,build: bump golang and golangci-lint versions.
klihub Apr 16, 2026
0777ae6
all: use log.{Debug,Info,Warn,Error}f consistently everywhere.
klihub Apr 15, 2026
b4fc03f
pkg,cmd: fix linting errors.
klihub Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/setup-go@v5
with:
go-version-file: go.mod
- uses: golangci/golangci-lint-action@v8
- uses: golangci/golangci-lint-action@v9
with:
version: v2.4.0
version: v2.11.4
args: --timeout=10m
Comment thread
fmuyassarov marked this conversation as resolved.
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ GO_LINT := golint -set_exit_status
GO_FMT := gofmt
GO_VET := $(GO_CMD) vet
GO_DEPS := $(GO_CMD) list -f '{{ join .Deps "\n" }}'
GO_VERSION ?= 1.25.0
GO_VERSION ?= 1.26.0

GO_MODULES := $(shell $(GO_CMD) list ./...)
GO_SUBPKGS := $(shell find ./pkg -name go.mod | sed 's:/go.mod::g' | grep -v testdata | \
Expand Down Expand Up @@ -396,7 +396,7 @@ ginkgo-tests:
--covermode atomic \
--output-dir $(COVERAGE_PATH) \
--junit-report junit.xml \
--coverprofile $(COVERAGE_PATH)/coverprofile \
--coverprofile coverprofile \
--keep-separate-coverprofiles \
--succinct \
--skip-package $$(echo $(GO_SUBPKGS) | tr -s '\t ' ',') \
Expand Down
2 changes: 1 addition & 1 deletion cmd/config-manager/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.25
ARG GO_VERSION=1.26

FROM golang:${GO_VERSION}-bookworm AS builder

Expand Down
2 changes: 1 addition & 1 deletion cmd/mpolset/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.25
ARG GO_VERSION=1.26

FROM golang:${GO_VERSION}-bookworm AS builder

Expand Down
2 changes: 1 addition & 1 deletion cmd/plugins/balloons/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.25
ARG GO_VERSION=1.26

FROM golang:${GO_VERSION}-bookworm AS builder

Expand Down
Loading
Loading