Skip to content

Conversation

@MayorFaj
Copy link

@MayorFaj MayorFaj commented Dec 5, 2025

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #27674 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Fixes: #27674

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MayorFaj
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MayorFaj MayorFaj changed the title Update image volume options to replace "bind" with "anonymous" Update image volume options to replace bind with anonymous Dec 6, 2025
@MayorFaj MayorFaj force-pushed the fix-image-volume-docs branch from facdc46 to a69ac84 Compare December 6, 2025 12:23
Update documentation and autocomplete to use "anonymous" instead of "bind"
for image volume options, as "bind" is deprecated and "anonymous" is the
correct term for image volumes that are not explicitly bind-mounted.

Signed-off-by: MayorFaj <mayorfaj@gmail.com>
@MayorFaj MayorFaj force-pushed the fix-image-volume-docs branch from a69ac84 to 626da84 Compare December 6, 2025 12:24
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@MayorFaj
Copy link
Author

MayorFaj commented Dec 6, 2025

This PR corrects documentation strings in the code to use the accurate terminology "anonymous" instead of the misleading "bind" for the --image-volume option. The actual runtime behavior is unchanged - only help text and autocomplete suggestions are updated to reflect what the code already does.

The changes are:

  • cmd/podman/common/completion.go - Autocomplete suggestion strings
  • cmd/podman/common/create.go - CLI help text
  • docs/ - Documentation files

The existing test at test/system/160-volumes.bats:540 already uses --image-volume anonymous correctly, so no test updates are needed.

Could a maintainer please add the No New Tests label? This is a documentation/help text correction that doesn't change runtime behavior or introduce new functionality that could regress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect documentation for --image-volume option in podman run

1 participant