Feature/cmg 353 #912
Open
Feature/cmg 353 #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Drupal migration support and various improvements across the migration tool, including locale handling enhancements, path security fixes, and UI improvements.
Changes:
- Added comprehensive Drupal SQL-based migration with dynamic query generation, taxonomy support, and database connection handling
- Enhanced locale normalization to lowercase across all CMS types (Sitecore, Contentful, Drupal) for consistent mapping
- Improved path traversal security by replacing custom sanitization with standard Node.js path validation utilities
- Upgraded React Router to v7 with future flags for better navigation handling
Reviewed changes
Copilot reviewed 70 out of 94 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/migration-sitecore/libs/extractLocales.js | Adds lowercase normalization for locale extraction |
| upload-api/migration-sitecore/libs/contenttypes.js | Replaces platform-specific separator with forward slash for consistency |
| upload-api/migration-drupal/* | New Drupal migration utilities including helper functions, taxonomy extraction, and locale handling |
| upload-api/migration-contentful/libs/extractLocale.js | Enhances locale extraction with master locale prioritization and lowercase normalization |
| ui/src/utilities/functions.ts | Removes unused helper functions for file extensions and safe routing |
| ui/src/store/slice/migrationDataSlice.tsx | Adds deep merge logic for nested objects to prevent data loss |
| ui/src/services/api/migration.service.ts | Adds taxonomy API endpoint and improves code formatting |
| ui/src/pages/Migration/index.tsx | Implements auto-mapping for unmapped locales and improves error handling |
| ui/src/components/* | Various UI improvements including taxonomy field support, SQL connection handling, and form validation |
| api/src/utils/sanitize-path.utils.ts | Refactors path validation to use standard basename checking instead of custom allowlist |
| api/src/utils/optimized-query-builder.utils.ts | New utility for handling large Drupal datasets with batched queries |
| api/src/services/drupal/* | New Drupal migration services for queries, taxonomies, references, entries, assets, and locales |
| api/src/services/projects.service.ts | Adds MySQL configuration support and dynamic query generation for Drupal projects |
| api/src/services/migration.service.ts | Integrates Drupal migration workflow and improves path validation |
| api/src/models/project-lowdb.ts | Adds MySQL and taxonomy-related fields to project schema |
| package.json | Updates dependencies including React Router v7 and adds mysql2 |
Files not reviewed (3)
- api/package-lock.json: Language not supported
- ui/package-lock.json: Language not supported
- upload-api/migration-contentful/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ess and express-validator, and added new dev dependencies for improved functionality and security.
…ew services for taxonomy, locales, and content type mapping. Updated package dependencies and improved database connection handling. Added new utility functions for batch processing and optimized query building.
…g and improve data processing. Updated database connection logic for better error handling and logging. Cleaned up debug statements and ensured consistent data structure across functions.
…ed error logging. Implement path validation utilities to prevent traversal attacks in various services. Update content mapping logic to ensure safe key usage and preserve initial values for reset operations. Refactor file processing routes to sanitize inputs and validate paths before operations.
…pgrade react-router and react-router-dom to version 7.12.0, and replace deprecated packages in package-lock.json. Remove unused dependencies and enhance package-lock.json structure for better clarity.
… to streamline code and improve readability. Update logging levels from info to error where appropriate, and ensure consistent handling of locale data in migration processes.
sauravraw
force-pushed
the
feature/cmg-353
branch
from
747d6ce to
3cb162a
Compare
….json files for improved functionality and compatibility.
…nd 8.2.7 respectively in package-lock.json files, and remove deprecated external-editor package to enhance compatibility and reduce bloat.
…n for @contentstack/cli-utilities and downgrade @parcel/watcher and related dependencies to version 2.5.1 for improved compatibility. Adjust various package versions for consistency and stability.
…and package-lock.json for improved functionality and compatibility. Adjust other dependencies for consistency and stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.