Skip to content

Correctly set the span of abstract type identifiers #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soareschen merged 2 commits into from
Feb 18, 2026
Merged

Correctly set the span of abstract type identifiers #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2270805
Correctly set the span of abstract type identifiers
soareschen Feb 18, 2026
ca709f0
Restore formatting
soareschen Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/cgp-macro-lib/src/cgp_fn/substitute_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,11 @@ pub fn substitute_abstract_type(
&& let Some(replacement_ident) = type_spec.replace_ident(&ident)
{
let trait_path = &type_spec.trait_path;

out.extend(quote! {
< #context_type as #trait_path > :: #replacement_ident
});

replaced_ident = true;
break;
}
Expand Down
4 changes: 3 additions & 1 deletion crates/cgp-macro-lib/src/cgp_fn/use_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ impl UseTypeSpec {
pub fn replace_ident(&self, ident: &Ident) -> Option<Ident> {
for type_ident in &self.type_idents {
if type_ident.replacement_ident() == ident {
return Some(type_ident.type_ident.clone());
let mut new_ident = type_ident.type_ident.clone();
new_ident.set_span(ident.span());
return Some(new_ident);
}
}

Expand Down
Loading