Skip to content

Use php for coverage runs#79

Open
ohmyfelix wants to merge 1 commit intocontributte:masterfrom
ohmyfelix:chore/remove-phpdbg-coverage
Open

Use php for coverage runs#79
ohmyfelix wants to merge 1 commit intocontributte:masterfrom
ohmyfelix:chore/remove-phpdbg-coverage

Conversation

@ohmyfelix
Copy link
Contributor

Summary

Switch the Makefile coverage target from phpdbg to php so this repository follows the org-wide coverage runner change tracked in contributte/contributte#73.

Motivation

phpdbg is being removed from Contributte coverage targets. This keeps reCAPTCHA aligned with the new standard and with the shared CI workflow expectations.

Changes

  • replace -p phpdbg with -p php in both coverage target branches in Makefile

Testing

  • Tests pass locally (make tests)
  • Coverage runs locally
  • CI passes

Local make coverage currently fails in this environment because the installed PHP does not have Xdebug or PCOV enabled and the change intentionally no longer uses PHPDBG.

Replace phpdbg with php in the coverage Makefile target to match the org-wide coverage runner update.\n\nRelates to contributte/contributte#73.
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.32%. Comparing base (f1fdf03) to head (d718ced).
⚠️ Report is 14 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f1fdf03) and HEAD (d718ced). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (f1fdf03) HEAD (d718ced)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   86.11%   79.32%   -6.79%     
==========================================
  Files           7        8       +1     
  Lines         144      179      +35     
==========================================
+ Hits          124      142      +18     
- Misses         20       37      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant