Open
Conversation
Replace phpdbg with php in the coverage Makefile target to match the org-wide coverage runner update.\n\nRelates to contributte/contributte#73.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 86.11% 79.32% -6.79%
==========================================
Files 7 8 +1
Lines 144 179 +35
==========================================
+ Hits 124 142 +18
- Misses 20 37 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the
Makefilecoverage target fromphpdbgtophpso this repository follows the org-wide coverage runner change tracked in contributte/contributte#73.Motivation
phpdbgis being removed from Contributte coverage targets. This keepsreCAPTCHAaligned with the new standard and with the shared CI workflow expectations.Changes
-p phpdbgwith-p phpin bothcoveragetarget branches inMakefileTesting
make tests)Local
make coveragecurrently fails in this environment because the installed PHP does not have Xdebug or PCOV enabled and the change intentionally no longer uses PHPDBG.