Skip to content

Fix form render crash and invalid Flatpickr locale#152

Merged
coolsam726 merged 2 commits into
mainfrom
fix/form-render-and-locale
Jun 13, 2026
Merged

Fix form render crash and invalid Flatpickr locale#152
coolsam726 merged 2 commits into
mainfrom
fix/form-render-and-locale

Conversation

@coolsam726

Copy link
Copy Markdown
Owner

Summary

  • Fix Blade view calling $isReadOnly() after it was already evaluated to a bool, which caused "Value of type bool is not callable" when opening forms
  • Fix Flatpickr JS locale import so bundled l10n locales are read from the default export, preventing "invalid locale undefined" at init
  • Rebuild the dist Alpine component bundle

Test plan

  • vendor/bin/pest — 114 tests pass
  • Open a Filament form with Flatpickr::make() fields (date, datetime) and confirm the form loads without PHP or JS errors
  • Confirm the picker opens and selects dates correctly

The Blade view called $isReadOnly() after it was already evaluated to a bool, and the l10n import exposed locales under default so en was undefined at runtime.
@codecov-commenter

codecov-commenter commented Jun 13, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (472580e) to head (d771244).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #152   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       293       293           
===========================================
  Files              6         6           
  Lines            698       698           
===========================================
  Hits             698       698           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coolsam726 coolsam726 enabled auto-merge June 13, 2026 23:26
@coolsam726 coolsam726 merged commit a7c23a5 into main Jun 13, 2026
47 checks passed
@coolsam726 coolsam726 deleted the fix/form-render-and-locale branch June 13, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants