Install cmake config files to the correct path on windows - #28
Open
colugomusic wants to merge 1 commit into
Open
colugomusic wants to merge 1 commit into
colugomusic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why this branch is here, perhaps there is a good reason for it that I'm missing. But it results in CsLibGuardedConfig.cmake etc. being installed to
(install prefix)/cmake/CsLibGuarded/on Windows, which is not a valid installation location as per the CMake documentationAnd so
find_package(CsLibGuarded)will not be able to find the package at this location. Installing to(install prefix)/lib/cmake/CsLibGuardedon all platforms fixes this.