Skip to content

fix(#960): wrap app_goto_target coordinates in array #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copystring merged 1 commit into from
Dec 13, 2025
Merged

fix(#960): wrap app_goto_target coordinates in array #962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/socketHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class socketHandler {
const handler = this.adapter.deviceFeatureHandlers.get(duid);
if (!handler) throw new Error(`No handler for DUID ${duid}`);

await this.adapter.requestsHandler.command(handler, duid, "app_goto_target", points);
await this.adapter.requestsHandler.command(handler, duid, "app_goto_target", [points]);
Comment on lines 189 to +192
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid nesting goto target coordinates

The socket handler now wraps the validated [x,y] coordinates in another array before sending the command, so requestsHandler will emit [[x,y]] for app_goto_target calls coming from the websocket/map UI. The other call path for this command in src/main.ts (lines 259‑265) forwards the parsed JSON directly and documents the expected format as "[x,y]", so the backend and devices still expect a flat array. This inconsistency means goto commands sent via the socket now use a different shape and will be rejected while the state-based path still works. Please keep the payload shape consistent with the documented flat [x,y] format or update all callers/protocol handling together.

Useful? React with 👍 / 👎.

return { result: "ok" };
}

Expand Down