[Bug] Fix getWaterbodyData runtime error: waitForFeatures used before initialization#350
Open
Athina09 wants to merge 1 commit intocore-stack-org:developmentfrom
Open
Conversation
Made-with: Cursor
Athina09
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a potential runtime error in
src/actions/getWaterbodyData.jsxwherewaitForFeatures(declared withconst) could be referenced before initialization.What was wrong
Inside
getWaterbodyData, the code callswaitForFeatures(...)to await vector features (waterbody/MWS/ZOI). In the previous ordering,waitForFeatureswas defined later in the function body, which can throw aReferenceError(TDZ) and break the water dashboard loading flow.What changed
waitForFeatureshelper so it is declared before the first time it is used.Files changed
src/actions/getWaterbodyData.jsx