efi: install grub.cfg under new vendor during updates#1033
Open
HuijingHei wants to merge 2 commits intocoreos:mainfrom
Open
efi: install grub.cfg under new vendor during updates#1033HuijingHei wants to merge 2 commits intocoreos:mainfrom
HuijingHei wants to merge 2 commits intocoreos:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with grub.cfg placement during OS updates that involve a change in the EFI vendor. The logic added to src/efi.rs correctly handles this by installing the configuration for the new vendor and cleaning up the old one. The changes in src/grubconfigs.rs are beneficial refactorings that improve code quality. I've identified a couple of areas in src/efi.rs where the implementation could be made more robust and consistent with the project's design patterns.
HuijingHei
force-pushed
the
update-with-new-vendor
branch
3 times, most recently
from
9608769 to
ed80429
Compare
HuijingHei
force-pushed
the
update-with-new-vendor
branch
2 times, most recently
from
86f9b26 to
5982e19
Compare
HuijingHei
force-pushed
the
update-with-new-vendor
branch
from
5982e19 to
880df51
Compare
HuijingHei
force-pushed
the
update-with-new-vendor
branch
from
880df51 to
0125061
Compare
When doing switches from RHEL 10 to Fedora 43, after reboot, check `grub.cfg` and `bootuuid.cfg` are in old vendor, that will make the machine failed to boot a second time since `grub.cfg` cannot be found. We need to install the two files under new vendor during updates. See coreos#1024
HuijingHei
force-pushed
the
update-with-new-vendor
branch
from
0125061 to
bb79b4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing switches from RHEL 10 to Fedora 43, after reboot, check
grub.cfg and bootuuid.cfg are in old vendor redhat, that will make
the machine fails to boot a second time since grub.cfg cannot be
found.
We need to install the 2 files under new vendor during updates.
See #1024