Skip to content

fix: separate Google and GitHub sign-in options in auth login #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinhelmer merged 1 commit into from
Aug 20, 2026
Merged

fix: separate Google and GitHub sign-in options in auth login #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/commands/auth/login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,12 @@ export const authLoginCommand: Command = {

// The one and only method question — the flow signs you up when the
// account doesn't exist yet, so the label says so.
const method = await promptSelect<'browser' | 'email' | 'device' | 'api-key'>(
const method = await promptSelect<'google' | 'github' | 'email' | 'device' | 'api-key'>(
{ nonInteractive: config.nonInteractive },
'Sign in (or sign up) with',
[
{ value: 'browser', label: 'GitHub or Google (browser)', hint: 'Recommended' },
{ value: 'google', label: 'Google', hint: 'opens your browser' },
{ value: 'github', label: 'GitHub', hint: 'opens your browser' },
Comment thread
justinhelmer marked this conversation as resolved.
{ value: 'email', label: 'Email' },
{ value: 'device', label: 'Device code', hint: 'no browser on this machine' },
Comment thread
justinhelmer marked this conversation as resolved.
{ value: 'api-key', label: 'API key', hint: 'For scripts / CI' },
Expand All @@ -235,7 +236,7 @@ export const authLoginCommand: Command = {
return;
}

await oauthLogin(config, true);
await oauthLogin(config, true, { provider: method });

// Suppress unused-variable lint when we don't use args later
void flags;
Comment thread
justinhelmer marked this conversation as resolved.
Expand Down
Loading