Feature/147 serializer turtle jsonld rdfxml#165
Merged
remiceres merged 27 commits intoJul 9, 2025
Conversation
|
MaillPierre
requested changes
Jun 27, 2025
Contributor
MaillPierre
left a comment
MaillPierre
left a comment
There was a problem hiding this comment.
Cf comment on the re-definition of URIs related string in SerializationConstants
| } | ||
|
|
||
| // --- Standard RDF/RDFS/XSD/OWL URIs --- | ||
| public static final String RDF_NS = "http://www.w3.org/1999/02/22-rdf-syntax-ns#"; |
Contributor
There was a problem hiding this comment.
All the RDF/RDFS related strings should be imported from src/main/java/fr/inria/corese/core/next/impl/common/vocabulary/RDFS.java and src/main/java/fr/inria/corese/core/next/impl/common/vocabulary/RDF.java instead of being re-defined here.
It woul probably also be a good ideau to add an OWL.java in the vocabulary package
Contributor
Author
There was a problem hiding this comment.
C’est corrigé
|
abdessamad-abdoun
force-pushed
the
feature/147_Serializer_Turtle_JSONLD_RDFXML
branch
from
e723efc to
dc6e183
Compare
|
remiceres
reviewed
Jun 30, 2025
Contributor
remiceres
left a comment
remiceres
left a comment
There was a problem hiding this comment.
- It might be beneficial to introduce inheritance between closely related serializers (e.g., N-Triples and N-Quads, TriG and Turtle) to reduce code duplication.
- Consider whether each serializer should have its own specific
FormatConfigtype, instead of sharing a common one.
Contributor
There was a problem hiding this comment.
Interface names should not be prefixed with "I". For example, use RdfSerializer instead of IRdfSerializer, as defined in our naming conventions:
https://github.com/corese-stack/corese-docs/blob/main/Naming%20and%20Coding%20Conventions%20for%20Corese.md/#L8-L13
Contributor
There was a problem hiding this comment.
Interface names should not be prefixed with "I". For example, use RdfSerializer instead of IRdfSerializer, as defined in our naming conventions:
https://github.com/corese-stack/corese-docs/blob/main/Naming%20and%20Coding%20Conventions%20for%20Corese.md/#L8-L13
Contributor
There was a problem hiding this comment.
Interface names should not be prefixed with "I". For example, use RdfSerializer instead of IRdfSerializer, as defined in our naming conventions:
https://github.com/corese-stack/corese-docs/blob/main/Naming%20and%20Coding%20Conventions%20for%20Corese.md/#L8-L13
Contributor
There was a problem hiding this comment.
Missing documentation for the RdfSerializer interface.
Contributor
There was a problem hiding this comment.
Missing documentation for the SerializerFactory interface.
Contributor
There was a problem hiding this comment.
Missing class-level Javadoc for NQuadsSerializer.
Contributor
There was a problem hiding this comment.
Missing Javadoc for SerializationException. Also, the existing comment is in French — all documentation should be written in English.
Contributor
There was a problem hiding this comment.
The name FormatConfig might be too generic — something like SerializerConfig could be more explicit.
|
|
|
|
|
|
|
Add a (possibly empty) Config interface for config objects
…mplémentation complète de RdfSerializationUtils
Add a (possibly empty) Config interface for config objects
Extracts a common abstract base class, AbstractLineBasedSerializer, from NQuadsSerializer and NTriplesSerializer. This refactoring removes duplicated code for writing statements, values, literals, IRIs, and blank nodes. The new base class centralizes the logic for line-by-line serialization, while subclasses (NQuadsSerializer and NTriplesSerializer) now only need to implement the specific logic for handling contexts (named graphs). - NQuadsSerializer handles the optional context. - NTriplesSerializer ignores the context and logs a warning. This change improves maintainability and reduces code duplication.
…t de la documentation manquante
abdessamad-abdoun
force-pushed
the
feature/147_Serializer_Turtle_JSONLD_RDFXML
branch
from
a7ff164 to
3783b50
Compare
|
|
remiceres
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.