89 Create JSONLD parser by MaillPierre · Pull Request #171 · corese-stack/corese-core

MaillPierre · 2025-07-10T09:48:35Z

JSONLD parser based on Titanium-jsonld + reorgnization of the packages and unification of the class names

…_parser

…e/89_json_parser

- add factory to listenerImpl

…/89_json_parser

…e/89_json_parser

github-actions · 2025-07-10T09:54:13Z

Overall Project	48.68% `-0.22%`	🍏
Files changed	67.23%	🍏

File	Coverage
NTriplesOption.java	100%	🍏
NQuadsOption.java	100%	🍏
CoreConfig.java	100%	🍏
BlankNodeStyleEnum.java	100%	🍏
LiteralDatatypePolicyEnum.java	100%	🍏
PrefixOrderingEnum.java	100%	🍏
AbstractNFamilyOption.java	100%	🍏
AbstractSerializerOption.java	100%	🍏
SerializationConstants.java	100%	🍏
AbstractIOOptions.java	100%	🍏
TriGOption.java	100%	🍏
RDFFormat.java	99.26%	🍏
FileFormat.java	98.53%	🍏
XmlOption.java	95.47%	🍏
TurtleOption.java	93.85% `-6.15%`	❌
CoreseTyped.java	93.59%	🍏
AbstractRDFParser.java	91.49% `-8.51%`	🍏
DataFrom.java	91.46%	🍏
AbstractTFamilyOption.java	91.09%	🍏
JSONLDSerializer.java	87.1% `-12.9%`	🍏
NTriplesSerializer.java	85.71% `-11.43%`	❌
XmlSerializer.java	81.4% `-0.34%`	❌
TitaniumJSONLDProcessorOption.java	79.49% `-20.51%`	🍏
JSONLDParser.java	79.45% `-20.55%`	🍏
AbstractLineBasedSerializer.java	77.76%	🍏
DefaultSerializerFactory.java	73.06% `-11.4%`	🍏
NQuadsSerializer.java	71.43% `-8.16%`	❌
CoreseValueConverter.java	66.96%	🍏
SerializationException.java	64.56% `-10.13%`	❌
TurtleListenerImpl.java	62.47% `-1.77%`	❌
AbstractGraphSerializer.java	58.36% `-3.29%`	🍏
ANTLRTurtleParser.java	56.47% `-9.41%`	🍏
TitaniumRDFDatasetSerializationAdapter.java	56.34% `-43.66%`	❌
TriGSerializer.java	54.56% `-2.81%`	❌
Property.java	38.12% `-0.39%`	❌
AbstractRDFParserFactory.java	30% `-70%`	❌
TurtleSerializer.java	24.45% `-5.84%`	❌
ParserFactory.java	21.82% `-78.18%`	❌
ParsingErrorException.java	0%	🍏
UnsupportedFileFormatException.java	0%	🍏

github-actions · 2025-07-10T09:54:32Z

Test Results

761 tests +29 761 ✅ +29 29s ⏱️ ±0s
50 suites + 4 0 💤 ± 0
50 files + 4 0 ❌ ± 0

Results for commit 9cd6442. ± Comparison against base commit b65464f.

♻️ This comment has been updated with latest results.

github-actions · 2025-07-10T13:06:40Z

Overall Project	48.68% `-0.22%`	🍏
Files changed	67.23%	🍏

File	Coverage
NTriplesOption.java	100%	🍏
NQuadsOption.java	100%	🍏
CoreConfig.java	100%	🍏
BlankNodeStyleEnum.java	100%	🍏
LiteralDatatypePolicyEnum.java	100%	🍏
PrefixOrderingEnum.java	100%	🍏
AbstractNFamilyOption.java	100%	🍏
AbstractSerializerOption.java	100%	🍏
SerializationConstants.java	100%	🍏
AbstractIOOptions.java	100%	🍏
TriGOption.java	100%	🍏
RDFFormat.java	99.26%	🍏
FileFormat.java	98.53%	🍏
XmlOption.java	95.47%	🍏
TurtleOption.java	93.85% `-6.15%`	❌
CoreseTyped.java	93.59%	🍏
AbstractRDFParser.java	91.49% `-8.51%`	🍏
DataFrom.java	91.46%	🍏
AbstractTFamilyOption.java	91.09%	🍏
JSONLDSerializer.java	87.1% `-12.9%`	🍏
NTriplesSerializer.java	85.71% `-11.43%`	❌
XmlSerializer.java	81.4% `-0.34%`	❌
TitaniumJSONLDProcessorOption.java	79.49% `-20.51%`	🍏
JSONLDParser.java	79.45% `-20.55%`	🍏
AbstractLineBasedSerializer.java	77.76%	🍏
DefaultSerializerFactory.java	73.06% `-11.4%`	🍏
NQuadsSerializer.java	71.43% `-8.16%`	❌
CoreseValueConverter.java	66.96%	🍏
SerializationException.java	64.56% `-10.13%`	❌
TurtleListenerImpl.java	62.47% `-1.77%`	❌
AbstractGraphSerializer.java	58.36% `-3.29%`	🍏
ANTLRTurtleParser.java	56.47% `-9.41%`	🍏
TitaniumRDFDatasetSerializationAdapter.java	56.34% `-43.66%`	❌
TriGSerializer.java	54.56% `-2.81%`	❌
Property.java	38.12% `-0.39%`	❌
AbstractRDFParserFactory.java	30% `-70%`	❌
TurtleSerializer.java	24.45% `-5.84%`	❌
ParserFactory.java	21.82% `-78.18%`	❌
ParsingErrorException.java	0%	🍏
UnsupportedFileFormatException.java	0%	🍏

remiceres

Great work, the structure is clear and the implementation looks solid.

I just have 2 requests for you to consider:

What is the purpose of the connectedMode.json file?
Please add Javadoc comments to all the following classes and their methods.

Let me know if you have any questions!

github-actions · 2025-07-16T15:38:10Z

Overall Project	48.68% `-0.22%`	🍏
Files changed	67.23%	🍏

File	Coverage
NTriplesOption.java	100%	🍏
NQuadsOption.java	100%	🍏
CoreConfig.java	100%	🍏
BlankNodeStyleEnum.java	100%	🍏
LiteralDatatypePolicyEnum.java	100%	🍏
PrefixOrderingEnum.java	100%	🍏
AbstractNFamilyOption.java	100%	🍏
AbstractSerializerOption.java	100%	🍏
SerializationConstants.java	100%	🍏
AbstractIOOptions.java	100%	🍏
TriGOption.java	100%	🍏
RDFFormat.java	99.26%	🍏
FileFormat.java	98.53%	🍏
XmlOption.java	95.47%	🍏
TurtleOption.java	93.85% `-6.15%`	❌
CoreseTyped.java	93.59%	🍏
AbstractRDFParser.java	91.49% `-8.51%`	🍏
DataFrom.java	91.46%	🍏
AbstractTFamilyOption.java	91.09%	🍏
JSONLDSerializer.java	87.1% `-12.9%`	🍏
NTriplesSerializer.java	85.71% `-11.43%`	❌
XmlSerializer.java	81.4% `-0.34%`	❌
TitaniumJSONLDProcessorOption.java	79.49% `-20.51%`	🍏
JSONLDParser.java	79.45% `-20.55%`	🍏
AbstractLineBasedSerializer.java	77.76%	🍏
DefaultSerializerFactory.java	73.06% `-11.4%`	🍏
NQuadsSerializer.java	71.43% `-8.16%`	❌
CoreseValueConverter.java	66.96%	🍏
SerializationException.java	64.56% `-10.13%`	❌
TurtleListenerImpl.java	62.47% `-1.77%`	❌
AbstractGraphSerializer.java	58.36% `-3.29%`	🍏
ANTLRTurtleParser.java	56.47% `-9.41%`	🍏
TitaniumRDFDatasetSerializationAdapter.java	56.34% `-43.66%`	❌
TriGSerializer.java	54.56% `-2.81%`	❌
Property.java	38.12% `-0.39%`	❌
AbstractRDFParserFactory.java	30% `-70%`	❌
TurtleSerializer.java	24.45% `-5.84%`	❌
ParserFactory.java	21.82% `-78.18%`	❌
ParsingErrorException.java	0%	🍏
UnsupportedFileFormatException.java	0%	🍏

MaillPierre · 2025-07-17T12:33:30Z

Comments have been added @remiceres . Check if everything is there.

github-actions · 2025-07-17T14:02:18Z

Overall Project	48.67% `-0.22%`	🍏
Files changed	66.39%	🍏

File	Coverage
NTriplesOption.java	100%	🍏
NQuadsOption.java	100%	🍏
CoreConfig.java	100%	🍏
BlankNodeStyleEnum.java	100%	🍏
LiteralDatatypePolicyEnum.java	100%	🍏
PrefixOrderingEnum.java	100%	🍏
AbstractNFamilyOption.java	100%	🍏
AbstractSerializerOption.java	100%	🍏
SerializationConstants.java	100%	🍏
AbstractIOOptions.java	100%	🍏
TriGOption.java	100%	🍏
RDFFormat.java	99.26%	🍏
FileFormat.java	98.53%	🍏
XmlOption.java	95.47%	🍏
TurtleOption.java	93.85% `-6.15%`	❌
CoreseTyped.java	93.59%	🍏
AbstractRDFParser.java	91.49% `-8.51%`	🍏
DataFrom.java	91.46%	🍏
AbstractTFamilyOption.java	91.09%	🍏
JSONLDSerializer.java	87.1% `-12.9%`	🍏
NTriplesSerializer.java	85.71% `-11.43%`	❌
XmlSerializer.java	81.4% `-0.34%`	❌
TitaniumJSONLDProcessorOption.java	79.49% `-20.51%`	🍏
JSONLDParser.java	79.45% `-20.55%`	🍏
AbstractLineBasedSerializer.java	77.76%	🍏
DefaultSerializerFactory.java	73.06% `-11.4%`	🍏
NQuadsSerializer.java	71.43% `-8.16%`	❌
CoreseValueConverter.java	66.96%	🍏
SerializationException.java	64.56% `-10.13%`	❌
TurtleListenerImpl.java	62.47% `-1.77%`	❌
AbstractGraphSerializer.java	58.36% `-3.29%`	🍏
ANTLRTurtleParser.java	56.47% `-9.41%`	🍏
TriGSerializer.java	54.56% `-2.81%`	❌
TitaniumRDFDatasetSerializationAdapter.java	53.13% `-46.88%`	❌
Property.java	38.12% `-0.39%`	❌
AbstractRDFParserFactory.java	30% `-70%`	❌
TurtleSerializer.java	24.45% `-5.84%`	❌
ParserFactory.java	21.82% `-78.18%`	❌
ParsingErrorException.java	0%	🍏
UnsupportedFileFormatException.java	0%	🍏

github-actions · 2025-07-18T13:02:06Z

Overall Project	48.67% `-0.22%`	🍏
Files changed	66.39%	🍏

File	Coverage
NTriplesOption.java	100%	🍏
NQuadsOption.java	100%	🍏
CoreConfig.java	100%	🍏
BlankNodeStyleEnum.java	100%	🍏
LiteralDatatypePolicyEnum.java	100%	🍏
PrefixOrderingEnum.java	100%	🍏
AbstractNFamilyOption.java	100%	🍏
AbstractSerializerOption.java	100%	🍏
SerializationConstants.java	100%	🍏
AbstractIOOptions.java	100%	🍏
TriGOption.java	100%	🍏
RDFFormat.java	99.26%	🍏
FileFormat.java	98.53%	🍏
XmlOption.java	95.47%	🍏
TurtleOption.java	93.85% `-6.15%`	❌
CoreseTyped.java	93.59%	🍏
AbstractRDFParser.java	91.49% `-8.51%`	🍏
DataFrom.java	91.46%	🍏
AbstractTFamilyOption.java	91.09%	🍏
JSONLDSerializer.java	87.1% `-12.9%`	🍏
NTriplesSerializer.java	85.71% `-11.43%`	❌
XmlSerializer.java	81.4% `-0.34%`	❌
TitaniumJSONLDProcessorOption.java	79.49% `-20.51%`	🍏
JSONLDParser.java	79.45% `-20.55%`	🍏
AbstractLineBasedSerializer.java	77.76%	🍏
DefaultSerializerFactory.java	73.06% `-11.4%`	🍏
NQuadsSerializer.java	71.43% `-8.16%`	❌
CoreseValueConverter.java	66.96%	🍏
SerializationException.java	64.56% `-10.13%`	❌
TurtleListenerImpl.java	62.47% `-1.77%`	❌
AbstractGraphSerializer.java	58.36% `-3.29%`	🍏
ANTLRTurtleParser.java	56.47% `-9.41%`	🍏
TriGSerializer.java	54.56% `-2.81%`	❌
TitaniumRDFDatasetSerializationAdapter.java	53.13% `-46.88%`	❌
Property.java	38.12% `-0.39%`	❌
AbstractRDFParserFactory.java	30% `-70%`	❌
TurtleSerializer.java	24.45% `-5.84%`	❌
ParserFactory.java	21.82% `-78.18%`	❌
ParsingErrorException.java	0%	🍏
UnsupportedFileFormatException.java	0%	🍏

github-actions · 2025-07-18T13:31:48Z

Overall Project	48.67% `-0.22%`	🍏
Files changed	66.39%	🍏

File	Coverage
NTriplesOption.java	100%	🍏
NQuadsOption.java	100%	🍏
CoreConfig.java	100%	🍏
BlankNodeStyleEnum.java	100%	🍏
LiteralDatatypePolicyEnum.java	100%	🍏
PrefixOrderingEnum.java	100%	🍏
AbstractNFamilyOption.java	100%	🍏
AbstractSerializerOption.java	100%	🍏
SerializationConstants.java	100%	🍏
AbstractIOOptions.java	100%	🍏
TriGOption.java	100%	🍏
RDFFormat.java	99.26%	🍏
FileFormat.java	98.53%	🍏
XmlOption.java	95.47%	🍏
TurtleOption.java	93.85% `-6.15%`	❌
CoreseTyped.java	93.59%	🍏
AbstractRDFParser.java	91.49% `-8.51%`	🍏
DataFrom.java	91.46%	🍏
AbstractTFamilyOption.java	91.09%	🍏
JSONLDSerializer.java	87.1% `-12.9%`	🍏
NTriplesSerializer.java	85.71% `-11.43%`	❌
XmlSerializer.java	81.4% `-0.34%`	❌
TitaniumJSONLDProcessorOption.java	79.49% `-20.51%`	🍏
JSONLDParser.java	79.45% `-20.55%`	🍏
AbstractLineBasedSerializer.java	77.76%	🍏
DefaultSerializerFactory.java	73.06% `-11.4%`	🍏
NQuadsSerializer.java	71.43% `-8.16%`	❌
CoreseValueConverter.java	66.96%	🍏
SerializationException.java	64.56% `-10.13%`	❌
TurtleListenerImpl.java	62.47% `-1.77%`	❌
AbstractGraphSerializer.java	58.36% `-3.29%`	🍏
ANTLRTurtleParser.java	56.47% `-9.41%`	🍏
TriGSerializer.java	54.56% `-2.81%`	❌
TitaniumRDFDatasetSerializationAdapter.java	53.13% `-46.88%`	❌
Property.java	38.12% `-0.39%`	❌
AbstractRDFParserFactory.java	30% `-70%`	❌
TurtleSerializer.java	24.45% `-5.84%`	❌
ParserFactory.java	21.82% `-78.18%`	❌
ParsingErrorException.java	0%	🍏
UnsupportedFileFormatException.java	0%	🍏

…on configuration

remiceres · 2025-07-21T15:20:45Z

I made a small change to the build.gradle.kts file to ensure that the files generated by ANTLR are properly recognized by my IDE (VSCode).

All other modifications are purely cosmetic:

removal of warnings,
added missing documentation,
formatting changes automatically applied by my IDE.

I plan to set up a shared formatting configuration soon to avoid these kinds of differences in the future.

github-actions · 2025-07-21T15:23:26Z

Overall Project	48.67% `-0.22%`	🍏
Files changed	66.39%	🍏

File	Coverage
NTriplesOption.java	100%	🍏
NQuadsOption.java	100%	🍏
CoreConfig.java	100%	🍏
BlankNodeStyleEnum.java	100%	🍏
LiteralDatatypePolicyEnum.java	100%	🍏
PrefixOrderingEnum.java	100%	🍏
AbstractNFamilyOption.java	100%	🍏
AbstractSerializerOption.java	100%	🍏
SerializationConstants.java	100%	🍏
AbstractIOOptions.java	100%	🍏
TriGOption.java	100%	🍏
RDFFormat.java	99.26%	🍏
FileFormat.java	98.53%	🍏
XmlOption.java	95.47%	🍏
TurtleOption.java	93.85% `-6.15%`	❌
CoreseTyped.java	93.59%	🍏
AbstractRDFParser.java	91.49% `-8.51%`	🍏
DataFrom.java	91.46%	🍏
AbstractTFamilyOption.java	91.09%	🍏
JSONLDSerializer.java	87.1% `-12.9%`	🍏
NTriplesSerializer.java	85.71% `-11.43%`	❌
XmlSerializer.java	81.4% `-0.34%`	❌
TitaniumJSONLDProcessorOption.java	79.49% `-20.51%`	🍏
JSONLDParser.java	79.45% `-20.55%`	🍏
AbstractLineBasedSerializer.java	77.76%	🍏
DefaultSerializerFactory.java	73.06% `-11.4%`	🍏
NQuadsSerializer.java	71.43% `-8.16%`	❌
CoreseValueConverter.java	66.96%	🍏
SerializationException.java	64.56% `-10.13%`	❌
TurtleListenerImpl.java	62.47% `-1.77%`	❌
AbstractGraphSerializer.java	58.36% `-3.29%`	🍏
ANTLRTurtleParser.java	56.47% `-9.41%`	🍏
TriGSerializer.java	54.56% `-2.81%`	❌
TitaniumRDFDatasetSerializationAdapter.java	53.13% `-46.88%`	❌
Property.java	38.12% `-0.39%`	❌
AbstractRDFParserFactory.java	30% `-70%`	❌
TurtleSerializer.java	24.45% `-5.84%`	❌
ParserFactory.java	21.82% `-78.18%`	❌
ParsingErrorException.java	0%	🍏
UnsupportedFileFormatException.java	0%	🍏

MaillPierre and others added 30 commits June 4, 2025 17:02

RDF formats

154f0cb

Barebone RDFParser Factory

9dcbfd1

Merge branch 'feature/87_89_144_152_155_parsers' into feature/89_json…

c8015fe

…_parser

barebone parser interface

81ceb4b

barebone parser interface

1463e4a

Merge branch 'feature/87_89_144_152_155_parsers' into feature/89_json…

165a871

…_parser

First draft with consumer implementation

9401042

Merge branch 'feature/corese-next' into feature/89_json_parser

1dc4961

Json parser redone ffrom scratch using Jsonld-java

c0cb9c0

Unit tests

72bf0b7

fix literal typing during parsing

a33d70b

TurtleParser and turtle g4

4012ee7

Merge remote-tracking branch 'origin/feature/corese-next' into featur…

fb2b2ec

…e/89_json_parser

basic JSONLD implementation with titanium

f286b90

better package organization

9c06cfc

Basic jsonld serializer

ad06072

better config

6a97a73

TurtleParser and turtle g4

00eb748

- changes in the package structure

c9b2f73

- add factory to listenerImpl

Merge remote-tracking branch 'origin/feature/87_parsers' into feature…

df57629

…/89_json_parser

Unifying PR and A implementations

737fe5c

UT test with graph probem to solve before push

af11856

Fixing Object handling in json parsing

21ad8ff

Merge remote-tracking branch 'origin/feature/corese-next' into featur…

5614afa

…e/89_json_parser

Merge remote-tracking branch 'origin/feature/corese-next' into featur…

de37817

…e/89_json_parser

Spring prunning of the package tree and UTs

57d2dcb

remove old shex file

0915c25

Paser with UT

924243a

jsonld UT init

170eca8

fix my personal page

11b6e4d

MaillPierre added 5 commits July 9, 2025 11:14

refining json serializer

e4b1fb9

Fixed Typed Literal bug

99e5e34

Merge branch 'feature/corese-next' into feature/89_json_parser

fc1ba51

fixing Exception heritage

9a35945

Reorganizing and standardizing classes and packages

0f9221d

MaillPierre added the Refactoring Issue created during the 2025 refactoring effort label Jul 10, 2025

MaillPierre assigned abdessamad-abdoun Jul 10, 2025

MaillPierre assigned remiceres Jul 10, 2025

abdessamad-abdoun reviewed Jul 10, 2025

View reviewed changes

Fixing test names and packages following review

baed5bc

remiceres reviewed Jul 16, 2025

View reviewed changes

removing unwanted file

cf4f824

Comments, comments everywhere

cd1ac3b

Refactor build.gradle.kts to enhance JavaCC and Antlr source generati…

9cd6442

…on configuration

remiceres merged commit 5922dce into feature/corese-next Jul 21, 2025
2 checks passed

remiceres deleted the feature/89_json_parser branch July 21, 2025 15:25

Conversation

MaillPierre commented Jul 10, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

remiceres left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 16, 2025

Uh oh!

MaillPierre commented Jul 17, 2025

Uh oh!

github-actions Bot commented Jul 17, 2025

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

remiceres commented Jul 21, 2025

Uh oh!

github-actions Bot commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 10, 2025 •

edited

Loading