feature/86-RDFXML-parser

[prbblrypier]

This is the RDF/XML Parser.
This Parser is a basic that read an XML File and produce a Model

[github-actions]

Overall Project	48.71% -0.06%	🍏
Files changed	87.33%	🍏

File	Coverage
RdfXmlContext.java	100%	🍏
RdfXmlParser.java	91.3% -8.7%	🍏
RdfXmlUtils.java	82.86% -17.14%	🍏
AbstractStatement.java	2.56% -15.38%	❌
RdfXmlParserFactory.java	0%	❌

[github-actions]

Test Results

887 tests  +69   887 ✅ +69   34s ⏱️ -1s
 62 suites + 7     0 💤 ± 0 
 62 files   + 7     0 ❌ ± 0 

Results for commit fa1b4ad. ± Comparison against base commit e8859fa.

♻️ This comment has been updated with latest results.

[github-actions]

Overall Project	49.22% -0.05%	🍏
Files changed	89.51%	🍏

File	Coverage
RdfXmlContext.java	100%	🍏
RdfXmlParser.java	94.04% -5.96%	🍏
RdfXmlUtils.java	82.86% -17.14%	🍏
ParserFactory.java	70.54% -16.96%	❌
AbstractStatement.java	2.56% -15.38%	❌

[remiceres]

Hello Pierre-René,

Here is a first round of feedback on the XML parser development.

Below are the modifications I made myself so far:

• I did a rebase of your branch onto the current feature/corese-next branch. This was necessary because your branch was quite outdated, and it had diverged significantly from the current state of the codebase.
  You were working from a very old feature branch, which made the rebase quite difficult. For future PRs, please try to regularly rebase your branch onto the current develop to avoid large divergences—it will save time and prevent complex conflicts. The branch you were using was still on Java 11 with module definitions, which caused issues and conflicts in build.gradle.kts.
• I changed the superclass of RdfXmlParser. It was originally extending DefaultHandler, but all parsers must extend AbstractRDFParser.
• I removed the RdfXmlParserFactory and directly integrated your parser to ParserFactory, following the same pattern used for the other parsers.

Here’s what remains to be done:

• The Javadoc is incomplete in several places and does not always follow the standard Javadoc format. Please review and complete it accordingly.
• The handleStartElement method is too large and mixes multiple levels of logic (element type detection, stack management, triple creation, etc.). It should be split into smaller, more focused methods.
• All SAX/XML errors are currently wrapped in RuntimeException, which is not the practice followed by other parsers. Instead, use specific exceptions or return informative error messages.
• Rename the parser class to be consistent with the naming of the other parsers.
• Don’t hesitate to take inspiration from the existing parsers (e.g., NQuadsParser) to ensure consistency in style, naming, and structure.

Thanks!

[github-actions]

Overall Project	49.49% -0.11%	🍏
Files changed	84.28%	🍏

File	Coverage
RDFXMLContext.java	100%	🍏
RDFXMLParser.java	95.73% -4.27%	🍏
RDFXMLStatementEmitter.java	91.94% -8.06%	🍏
IRIUtils.java	87.12% -4.55%	🍏
RDFXMLUtils.java	83.85% -16.15%	🍏
TriGListerner.java	72.97% -27.03%	🍏
ParserFactory.java	70.54% -16.96%	❌
ANTLRTrigParser.java	47.92% -52.08%	❌
AbstractStatement.java	2.56% -15.38%	❌
CoreseInfo.java	0%	🍏

[MaillPierre]

Duplicate with src/main/java/fr/inria/corese/core/next/impl/io/serialization/util/SerializationConstants.java. Refer to it instead.

[prbblrypier]

I don't use SerializationConstants in my code.
Do you want me to remove src/main/java/fr/inria/corese/core/next/impl/common/serializer/util/SerializationConstants.java ?

[MaillPierre]

Yes

[github-actions]

Overall Project	49.59% -0.11%	🍏
Files changed	83.99%	🍏

File	Coverage
RDFXMLContext.java	100%	🍏
RDFXMLParser.java	95.73% -4.27%	🍏
RDFXMLStatementEmitter.java	91.94% -8.06%	🍏
RDFXMLUtils.java	83.85% -16.15%	🍏
IRIUtils.java	83.04% -1.38%	🍏
TriGListerner.java	72.97% -27.03%	🍏
ParserFactory.java	70.54% -16.96%	❌
ANTLRTrigParser.java	47.92% -52.08%	❌
AbstractStatement.java	2.56% -15.38%	❌
CoreseInfo.java	0%	🍏