Skip to content

Revert "Final code formatting and documentation improvements for JSON-LD parser"#180

Closed
remiceres wants to merge 271 commits into
developfrom
revert-178-feature/89_json_parser
Closed

Revert "Final code formatting and documentation improvements for JSON-LD parser"#180
remiceres wants to merge 271 commits into
developfrom
revert-178-feature/89_json_parser

Conversation

@remiceres
Copy link
Copy Markdown
Contributor

Reverts #178

MaillPierre and others added 30 commits February 12, 2025 16:20
remiceres and others added 25 commits July 7, 2025 17:03
Extracts a common abstract base class, AbstractLineBasedSerializer, from NQuadsSerializer and NTriplesSerializer.

This refactoring removes duplicated code for writing statements, values, literals, IRIs, and blank nodes.

The new base class centralizes the logic for line-by-line serialization, while subclasses (NQuadsSerializer and NTriplesSerializer) now only need to implement the specific logic for handling contexts (named graphs).

- NQuadsSerializer handles the optional context.
- NTriplesSerializer ignores the context and logs a warning.

This change improves maintainability and reduces code duplication.
…le_JSONLD_RDFXML

Feature/147 serializer turtle jsonld rdfxml
Final code formatting and documentation improvements for JSON-LD parser
@github-actions
Copy link
Copy Markdown

Overall Project 46.85% -2.39% 🍏
Files changed 34.19%

File Coverage
QueryProfile.java 100% 🍏
ExpType.java 100% 🍏
PointerType.java 100% 🍏
AlgType.java 100% 🍏
EdgeEntail.java 100% 🍏
EdgeDefault.java 100% 🍏
EdgeBinaryFirst.java 100% 🍏
EdgeBinaryType.java 100% 🍏
EdgeBinarySubclass.java 100% 🍏
EdgeBinaryLabel.java 100% 🍏
EdgeBinaryRest.java 100% 🍏
Log.java 100% 🍏
Loader.java 100% 🍏
EdgeRuleSubclass.java 100% 🍏
EdgeRuleType.java 100% 🍏
GraphObject.java 100% 🍏
Event.java 100% 🍏
HeuristicsBasedEstimation.java 99.46% 🍏
Jaro.java 98.82% -1.18% 🍏
EdgeManagerIterate.java 97.92% 🍏
JaroWinkler.java 97.33% -2.67% 🍏
MatchBind.java 96.77% 🍏
Const.java 96.3% 🍏
StrategyType.java 93.75% -6.25% 🍏
NodeIterator.java 92.68% -7.32% 🍏
DataStore.java 91.95% 🍏
NGram.java 90.51% -9.49% 🍏
EvalGraph.java 90.48% 🍏
SorterNew.java 89.96% 🍏
EdgeQuad.java 88.89% 🍏
NodeGraph.java 88% 🍏
DepthFirstBestSearch.java 87.7% 🍏
QPGEdgeCostModel.java 87.42% 🍏
CombinedAlgorithm.java 86.54% -13.46% 🍏
ApproximateStrategy.java 85.97% -14.03% 🍏
VisitQuery.java 85.78% 🍏
Expr.java 85.71% 🍏
CoreseJsonTripleCallback.java 85.62% 🍏
EdgeInternalRule.java 85% 🍏
ASTRewriter.java 83.55% -16.45% 🍏
AddTripleHelper.java 82.99% 🍏
Message.java 82.5% 🍏
QPGraph.java 81.88% 🍏
EdgeRule.java 81.03% 🍏
Record.java 80.67% 🍏
Interpreter.java 80.23% -10.17% 🍏
AppxSearchPlugin.java 79.29% -20.71% 🍏
Priority.java 78.3% -21.7% 🍏
Compile.java 78.29% 🍏
Sorter.java 78.16% 🍏
ApproximateSearchEnv.java 78.15% 🍏
Distinct.java 78.05% 🍏
Transformer.java 77.83% -3.37% 🍏
QPGNodeCostModel.java 77.74% 🍏
EdgeRuleTop.java 77.55% 🍏
QPGNode.java 77.16% 🍏
EdgeManager.java 74.57% 🍏
QuerySorter.java 73.58% 🍏
ExpHandler.java 73.43% 🍏
Memory.java 72.58% 🍏
EdgeBinary.java 72.46% 🍏
FunctionCompiler.java 71.79% -10.44%
NodeGraphIndex.java 71.79% 🍏
Group.java 70.74% 🍏
Matcher.java 70.73% 🍏
Distance.java 70.69% 🍏
CompilerFacKgram.java 70% -30% 🍏
EdgeInternalDefault.java 70% 🍏
EdgeInternalEntail.java 70% 🍏
SimAlgorithmFactory.java 69.74% -30.26% 🍏
PathFinder.java 69.05% 🍏
EventManager.java 68.53% -7.2% 🍏
XMLResult.java 67.73% -15.45% 🍏
MappingSet.java 67.45% 🍏
Query.java 67.07% 🍏
QuerySolver.java 66.51% -4.76% 🍏
Entailment.java 66.39% 🍏
Closure.java 66.28% 🍏
EdgeManagerIndexer.java 66.04% 🍏
EdgeInternal.java 65.85% 🍏
Eval.java 65.26% 🍏
EvalOptional.java 64.92% 🍏
QuerySolverVisitor.java 64.2% -3.31%
Producer.java 64.1% 🍏
UserImpl.java 63.76% 🍏
Workflow.java 62.82% -6.41% 🍏
NodeManager.java 62.75% 🍏
Parameters.java 62.62% -37.38% 🍏
NodeImpl.java 61.99% -1.75% 🍏
BaseAlgorithm.java 60% -40% 🍏
Visit.java 59.49% 🍏
CompilerKgram.java 58.51% -7.65%
Exp.java 58.44% 🍏
Path.java 57.19% 🍏
Load.java 56.85% 🍏
ProcessVisitorDefault.java 56.76% 🍏
EvalJoin.java 56.23% 🍏
XMLResult.java 55.88% 🍏
RuleLoad.java 55.54% 🍏
Mapping.java 54.66% 🍏
PredicateList.java 54.29% 🍏
EdgeGeneric.java 53.74% 🍏
QuerySolverVisitorBasic.java 53.48% -19.03%
Graph.java 53.47% -0.16% 🍏
EdgeFactory.java 52.92% -9.91% 🍏
StatListener.java 52.39% 🍏
Mappings.java 51.38% 🍏
BasicPatternGenerator.java 50.38% 🍏
RDFaLoader.java 49.28% 🍏
EdgeTop.java 46.72% 🍏
JsonldLoader.java 46.15% 🍏
EdgeImpl.java 42.2% -19.15%
ProcessVisitor.java 41.01% 🍏
ProxyInterpreter.java 40.59% -23.76%
TripleWrapper.java 38.89% -61.11%
QueryLoad.java 37.83% 🍏
Service.java 33.2% 🍏
Pragma.java 32.96% -38.01%
ServiceParser.java 29.75% 🍏
Pointerable.java 28.57% 🍏
Context.java 28.36% -20.9%
Node.java 27.08% 🍏
EdgeTriple.java 25.68% 🍏
Pattern.java 23.39% 🍏
NodeImpl.java 23.26% 🍏
EvalListener.java 21.91% 🍏
Stack.java 21.33% 🍏
ProducerDefault.java 20.19% 🍏
Edge.java 19.92% 🍏
QuerySolverOverload.java 19.9% -23.04%
Utils.java 18.57% -81.43%
ValueResolverImpl.java 15.87% -11.11%
LoadException.java 14.61% 🍏
ServiceReport.java 12.28% 🍏
Hash.java 11.76% -88.24%
CompleteSPARQL.java 4.48% 🍏
ExpEdge.java 4.37% 🍏
DataBrokerConstruct.java 3.03% 🍏
EvalSPARQL.java 2.81% 🍏
EnvironmentImpl.java 2.05% 🍏
Checker.java 1.6% 🍏
ExpandList.java 0% -18.18%
ExpandPath.java 0%
Extension.java 0%
Checker.java 0% -22.71%
NodeManagerBasic.java 0% 🍏
Environment.java 0% 🍏
Provider.java 0% 🍏
DepthFirstSearch.java 0% 🍏
Checker.java 0% 🍏
IterableEntity.java 0% 🍏
SPARQLRDFResult.java 0% 🍏
Stack.java 0% 🍏
Automaton.java 0% 🍏
GraphPath.java 0% 🍏
State.java 0% 🍏
ClassHierarchy.java 0%
Equality.java 0%
Core.java 0% 🍏
EdgeImpl.java 0% 🍏
TripleNode.java 0% 🍏
EdgeTripleNode.java 0% 🍏
RewriteError.java 0% -51.06%
ResourceReader.java 0% -12.5%
RewriteErrorManager.java 0% 🍏
QueryGraphVisitor.java 0% 🍏
GraphListener.java 0%
DataBroker.java 0% 🍏
Callback.java 0% 🍏
Extension.java 0% 🍏
Core.java 0% 🍏
Report.java 0% 🍏
JavaCompiler.java 0% 🍏
Agent.java 0% 🍏
EdgeRuleGraph.java 0% 🍏
MetadataVisitor.java 0% -21.69%
TraceVisitor.java 0% 🍏
QuerySolverVisitorExtension.java 0% -53.33%
SQLFun.java 0% -92.86%
Custom.java 0% -25%
SQLResult.java 0%
OWLRule.java 0% 🍏
BrokerDistanceDataManager.java 0% 🍏
CompareWithoutDatatypeEntailment.java 0% 🍏
GraphDistance.java 0% -15.17%
Start.java 0%
EventLogger.java 0% -46.48%
EventHandler.java 0% 🍏
Serializer.java 0% 🍏
GraphCompare.java 0% -1.86%
URI2BGPList.java 0% -22.44%
RewriteServiceGraph.java 0% -33.61%
RewriteServiceSelect.java 0% -23.88%
Stack.java 0% -42.59%
RewriteBGPList.java 0% -27.68%
Provenance.java 0% -45.16%
SorterResult.java 0% -5.95%
Simplify.java 0% -25.57%
Util.java 0% -44.14%
PrepareBGP.java 0% -12.11%
RewriteTriple.java 0% -16.83%
BGP2URI.java 0% -20.28%
Selector.java 0% -25.71%
SelectorFilter.java 0% -24.57%
RewriteList.java 0% -20.8%
SelectorIndex.java 0% -28.85%
RewriteService.java 0% -44.04%
Sorter.java 0% -31.41%
RewriteNamedGraph.java 0% -21.54%
SimplifyService.java 0% -19.78%
FederateVisitor.java 0% -25%

@github-actions
Copy link
Copy Markdown

Test Results

358 tests   - 402   358 ✅  - 402   24s ⏱️ -7s
 12 suites  -  38     0 💤 ±  0 
 12 files    -  38     0 ❌ ±  0 

Results for commit c5eda37. ± Comparison against base commit 25f3640.

This pull request removes 761 and adds 358 tests. Note that renamed tests count towards both.
 newline
fr.inria.corese.core.compiler.eval.HashTest ‑ test1()
fr.inria.corese.core.datatype.CoreseDateTest ‑ compareEqual()
fr.inria.corese.core.datatype.CoreseDateTest ‑ compareLessGreater()
fr.inria.corese.core.datatype.CoreseDateTest ‑ compareLessGreaterTimeZone()
fr.inria.corese.core.datatype.CoreseDateTest ‑ constructorEmpty()
fr.inria.corese.core.datatype.CoreseDateTest ‑ getCode()
fr.inria.corese.core.datatype.CoreseDateTest ‑ getDatatype()
fr.inria.corese.core.datatype.CoreseDateTest ‑ getTZ()
fr.inria.corese.core.datatype.CoreseDateTest ‑ getTimezone()
…
fr.inria.corese.core.approximate.algorithm.UtilsTest ‑ format1
fr.inria.corese.core.compiler.eval.HashTest ‑ test1
fr.inria.corese.core.datatype.CoreseDateTest ‑ compareEqual
fr.inria.corese.core.datatype.CoreseDateTest ‑ compareLessGreater
fr.inria.corese.core.datatype.CoreseDateTest ‑ compareLessGreaterTimeZone
fr.inria.corese.core.datatype.CoreseDateTest ‑ constructorEmpty
fr.inria.corese.core.datatype.CoreseDateTest ‑ getCode
fr.inria.corese.core.datatype.CoreseDateTest ‑ getDatatype
fr.inria.corese.core.datatype.CoreseDateTest ‑ getTZ
fr.inria.corese.core.datatype.CoreseDateTest ‑ getTimezone
…

@remiceres remiceres closed this Jul 21, 2025
@remiceres remiceres deleted the revert-178-feature/89_json_parser branch July 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants