Feature/230 prefix handling#235
Merged
abdessamad-abdoun merged 4 commits intoNov 28, 2025
Merged
Conversation
abdessamad-abdoun
requested review from
MaillPierre,
prbblrypier and
remiceres
|
remiceres
requested changes
Nov 21, 2025
Contributor
remiceres
left a comment
remiceres
left a comment
There was a problem hiding this comment.
The changes look good to me, thanks for the work. However, this introduces several new SonarQube issues, especially regarding entrySet usage, clone(), and exception handling. It would be better to avoid introducing new warnings and fix the existing ones in the modified file so that the overall number decreases with each change.
Could you address these before we merge?
Comment on lines
20
to
26
| import java.util.TreeMap; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import fr.inria.corese.core.next.impl.common.prefix.PrefixHandler; | ||
| import fr.inria.corese.core.next.impl.common.vocabulary.*; | ||
| import fr.inria.corese.core.next.impl.exception.ParsingErrorException; | ||
| import org.slf4j.Logger; |
|
MaillPierre
force-pushed
the
feature/230_prefix_handling
branch
from
2fbd543 to
c2e7c04
Compare
|
MaillPierre
approved these changes
Nov 24, 2025
VS Code wasn’t indexing `build/generated-src`, causing false missing-class errors. Adding the `eclipse` plugin fixes the classpath so VS Code loads the generated sources correctly.
remiceres
approved these changes
Nov 27, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.