Feature/14 fix rdfxml parserserializer to pass w3c test#249
Merged
abdessamad-abdoun merged 13 commits intoDec 11, 2025
Merged
Conversation
…e `factory.createLiteral("flargh", xsd:integer)`
…problemes de sonar
|
MaillPierre
approved these changes
Dec 9, 2025
MaillPierre
added
the
Refactoring
remiceres
requested changes
Dec 10, 2025
Contributor
remiceres
left a comment
remiceres
left a comment
There was a problem hiding this comment.
Overall the changes look good. I’ve left a few comments that should be addressed before merging, but nothing major. Once those are fixed, it will be ready to go.
| ctx.predicateStack.pop(); | ||
|
|
||
| if (RDFXMLUtils.isDescription(localName, uri) || RDFXMLUtils.isRdfNodeElementType(uri, localName)) { | ||
| if (!ctx.subjectStack.isEmpty()) { |
Contributor
There was a problem hiding this comment.
Merge this if statement with the enclosing one
| public class RDFXMLParser extends AbstractRDFParser { | ||
|
|
||
| /** RDF/XML format identifier for this parser. */ | ||
| private final RDFFormat format = RDFFormat.RDFXML; |
Contributor
There was a problem hiding this comment.
Make this final field static too
| @@ -144,20 +161,34 @@ private void handleCharacters(char[] ch, int start, int length) { | |||
| characters.append(ch, start, length); | |||
Contributor
There was a problem hiding this comment.
Move this method into "RdfXmlSaxHandler"
| * and special parseType attributes, updating the parsing context accordingly. | ||
| */ | ||
| private void handleStartElement(String uri, String localName, String qName, Attributes attrs) { | ||
| private void handleStartElement(String uri, String localName, String qName, Attributes attrs) |
Contributor
There was a problem hiding this comment.
Move this method into "RdfXmlSaxHandler"
| } | ||
| return Optional.empty(); | ||
|
|
||
| switch (localName) { |
Contributor
There was a problem hiding this comment.
Add a default case to this switch
| case "nodeID": | ||
| case "datatype": | ||
| case "aboutEach": | ||
| case "aboutEachPrefix": |
Contributor
There was a problem hiding this comment.
Merge the previous cases into this one using comma-separated label
| case "datatype": | ||
| case "Description": | ||
| case "aboutEach": | ||
| case "aboutEachPrefix": |
Contributor
There was a problem hiding this comment.
Merge the previous cases into this one using comma-separated label
| } | ||
|
|
||
| // According to RDF/XML spec section 5.1 | ||
| switch (localName) { |
Contributor
There was a problem hiding this comment.
Add a default case to this switch
| switch (parseType) { | ||
| case "Resource": | ||
| case "Literal": | ||
| case "Collection": |
Contributor
There was a problem hiding this comment.
Merge the previous cases into this one using comma-separated label.
Contributor
There was a problem hiding this comment.
Suggested change
| case "Collection": | |
| case "Resource", "Literal", "Collection": | |
| return; // Valid |
|
|
|
remiceres
approved these changes
Dec 10, 2025
| throw new ParsingErrorException("rdf:nodeID value '" + nodeID + "' is not a valid NCName. " + | ||
| "NCNames cannot contain colons and must start with a letter or underscore."); | ||
| } | ||
| return factory.createBNode(ParserConstants.BLANK_NODE_PREFIX + nodeID); |
Contributor
There was a problem hiding this comment.
Use static access with "fr.inria.corese.core.next.impl.io.common.IOConstants" for "BLANK_NODE_PREFIX".
| switch (parseType) { | ||
| case "Resource": | ||
| case "Literal": | ||
| case "Collection": |
Contributor
There was a problem hiding this comment.
Suggested change
| case "Collection": | |
| case "Resource", "Literal", "Collection": | |
| return; // Valid |
|
abdessamad-abdoun
deleted the
feature/14-fix-rdfxml-parserserializer-to-pass-w3c-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.