Skip to content

295 [SPARQL 1.0] Parser and AST : Dataset (FROM/ FROM NAMED)#324

Merged
MaillPierre merged 4 commits into
feature/corese-nextfrom
feature/295-sparql-10-parser-and-ast-dataset-from-from-named
Mar 25, 2026
Merged

295 [SPARQL 1.0] Parser and AST : Dataset (FROM/ FROM NAMED)#324
MaillPierre merged 4 commits into
feature/corese-nextfrom
feature/295-sparql-10-parser-and-ast-dataset-from-from-named

Conversation

@MaillPierre
Copy link
Copy Markdown
Contributor

@MaillPierre MaillPierre commented Mar 19, 2026

Adds the From/From Named

@MaillPierre MaillPierre self-assigned this Mar 19, 2026
@MaillPierre MaillPierre added the Refactoring Issue created during the 2025 refactoring effort label Mar 19, 2026
@MaillPierre MaillPierre force-pushed the feature/295-sparql-10-parser-and-ast-dataset-from-from-named branch from c8981ab to c32d0ba Compare March 19, 2026 15:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026 •
edited
Loading

Test Results

  367 files  + 1    367 suites  +1   42s ⏱️ -1s
2 007 tests + 3  2 007 ✅ + 3  0 💤 ±0  0 ❌ ±0 
2 020 runs  +15  2 020 ✅ +15  0 💤 ±0  0 ❌ ±0 

Results for commit 007e9e9. ± Comparison against base commit 6f8d8f1.

♻️ This comment has been updated with latest results.

@MaillPierre MaillPierre marked this pull request as draft March 19, 2026 15:40
@MaillPierre MaillPierre marked this pull request as ready for review March 19, 2026 15:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

Overall Project 49.16% -0.01% 🍏
Files changed 88.41% 🍏

File Coverage
DatasetClauseFeature.java 100% 🍏
AskQueryAst.java 100% 🍏
DescribeQueryAst.java 100% 🍏
SparqlParser.java 92.66% 🍏
SelectQueryAst.java 91.49% -4.26% 🍏
SparqlListener.java 90.42% 🍏
SparqlAstBuilder.java 79.46% -0.27% 🍏
DatasetClauseAst.java 74.19% -25.81% 🍏
ConstructQueryAst.java 0% -13.33% ❌

prbblrypier
prbblrypier requested changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@prbblrypier prbblrypier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In overall it's good, but I want to address the AST should be immutable. If two processes is using the SparqlAstBuilder it's good that have this safeguard.

Comment thread src/main/java/fr/inria/corese/core/next/query/impl/sparql/ast/AskQueryAst.java
Comment thread src/main/java/fr/inria/corese/core/next/query/impl/sparql/ast/DatasetClauseAst.java
Comment thread src/main/java/fr/inria/corese/core/next/query/impl/parser/SparqlAstBuilder.java Outdated
Comment thread src/main/java/fr/inria/corese/core/next/query/impl/parser/SparqlAstBuilder.java Outdated
Comment thread src/main/java/fr/inria/corese/core/next/query/impl/parser/SparqlAstBuilder.java
Comment thread src/main/java/fr/inria/corese/core/next/query/impl/parser/SparqlAstBuilder.java Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2026

Overall Project 49.16% 🍏
Files changed 90.66% 🍏

File Coverage
DatasetClauseFeature.java 100% 🍏
DescribeQueryAst.java 100% 🍏
SparqlParser.java 92.66% 🍏
SelectQueryAst.java 91.49% -4.26% 🍏
SparqlListener.java 90.42% 🍏
AskQueryAst.java 90% -10% ❌
DatasetClauseAst.java 88.57% -11.43% 🍏
SparqlAstBuilder.java 79.57% -0.26% 🍏
ConstructQueryAst.java 0% -13.33% ❌

@MaillPierre MaillPierre requested a review from prbblrypier March 20, 2026 10:41
@MaillPierre MaillPierre linked an issue Mar 20, 2026 that may be closed by this pull request
[SPARQL 1.0] Parser and AST : Dataset (FROM/ FROM NAMED) #295
Closed
@MaillPierre MaillPierre merged commit d2d0f55 into feature/corese-next Mar 25, 2026
2 checks passed
@MaillPierre MaillPierre deleted the feature/295-sparql-10-parser-and-ast-dataset-from-from-named branch March 25, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prbblrypier prbblrypier prbblrypier approved these changes

@abdessamad-abdoun abdessamad-abdoun abdessamad-abdoun approved these changes

Assignees

@MaillPierre MaillPierre

Labels

Refactoring Issue created during the 2025 refactoring effort

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SPARQL 1.0] Parser and AST : Dataset (FROM/ FROM NAMED)

3 participants

@MaillPierre @prbblrypier @abdessamad-abdoun