Fix information exposure in OrderInvoiceController and OrderShipmentController

[Copilot]

• Analyze the security vulnerability in OrderInvoiceController and OrderShipmentController
• Fix OrderInvoiceController.php: Replace exception message and stack trace exposure with generic error message
• Fix OrderShipmentController.php: Replace exception message and stack trace exposure with generic error message
• Address review feedback: Remove logging and simplify error response

Summary

This PR fixes a security vulnerability (Information Exposure) where internal error messages and stack traces were being returned directly to clients in case of server errors.

Changes Made

OrderInvoiceController.php (renderAction method)

• Return generic error message with HTTP 500 status code instead of exposing exception details

OrderShipmentController.php (renderAction method)

• Return generic error message with HTTP 500 status code instead of exposing exception details

Security Fix

Before: Exception messages and full stack traces were embedded directly into HTML responses sent to clients.

} catch (\Exception $e) {
    $responseData = '<strong>' . $e->getMessage() . '</strong><br>trace: ' . $e->getTraceAsString();
    $header = ['Content-Type' => 'text/html'];
}
return new Response($responseData, 200, $header);

After: Simple generic error message with HTTP 500 status.

} catch (\Exception $e) {
    return new Response('An error occurred while rendering the invoice.', 500, ['Content-Type' => 'text/html']);
}

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Information Exposure</issue_title>
<issue_description>Problem Statement
Internal error messages and stack traces are returned directly to the client in case of server errors.

Description

• Exception messages and full stack traces are embedded directly into HTML responses.
• Internal implementation details leave the server trust boundary.

Example

CoreShop/src/CoreShop/Bundle/OrderBundle/Controller/OrderInvoiceController.php

Line 189 in 3fcd9fb

$responseData = '<strong>' . $e->getMessage() . '</strong><br>trace: ' . $e->getTraceAsString();

CoreShop/src/CoreShop/Bundle/OrderBundle/Controller/OrderShipmentController.php

Line 185 in 3fcd9fb

$responseData = '<strong>' . $e->getMessage() . '</strong><br>trace: ' . $e->getTraceAsString();

Impact

• Disclosure of internal classes, file paths, and control flow.
• Easier analysis of the application architecture.
• Reduced effort for targeted follow-up attacks.

Mitigation

• Do not return exception messages or stack traces to clients.
• Use generic error messages in responses.
• Log detailed error information exclusively on the server side.

@raphael-kat @papillo-solutions</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Information Exposure #2953

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[dpfaffenbauer]

@copilot remove log and don't overexpose response

[Copilot]

Removed the logging and simplified the error response to just return a generic message with HTTP 500 status. Fixed in de3345e.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}