Skip to content

Update multivariate_normal.py to use loc instead of mean#2488

Open
chrisyeh96 wants to merge 3 commits intocornellius-gp:mainfrom
chrisyeh96:patch-4
Open

Update multivariate_normal.py to use loc instead of mean#2488
chrisyeh96 wants to merge 3 commits intocornellius-gp:mainfrom
chrisyeh96:patch-4

Conversation

@chrisyeh96
Copy link
Contributor

Update MultivariateNormal to better match torch.distributions.MultivariateNormal

Also, add typing annotation that allows loc to be a LinearOperator

Update MultivariateNormal to better match torch.distributions.MultivariateNormal

Also, add typing annotation that allows `loc` to be a LinearOperator
@Balandat
Copy link
Collaborator

Thanks. I expect this to cause some backward compatibility problems though, e.g. here in BoTorch. Not sure if it's worth the trouble of changing this in a way that deprecates the old arg name, but that's something you could do if you feel strongly about the renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants