Reshape Targets and Mean for RHS in Cholesky solver#2587
Open
turquoisedragon2926 wants to merge 2 commits intocornellius-gp:mainfrom
Open
Reshape Targets and Mean for RHS in Cholesky solver#2587turquoisedragon2926 wants to merge 2 commits intocornellius-gp:mainfrom
turquoisedragon2926 wants to merge 2 commits intocornellius-gp:mainfrom
Conversation
gpleiss
requested changes
Jan 28, 2025
Member
gpleiss
left a comment
There was a problem hiding this comment.
You should assume that all of the variable could come from batched GPs, so the reshape call could cause some issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential fix to #2577 bug regarding Fantasy Models for Multitask GPs
Code changes
Added reshaping to align
targetsandfant_meanin the calculation ofsmall_system_rhsto ensure proper tensor operations in the fantasy data update step for the GP model.Tests
None added
Documentation
None updated
Examples
In order to test, one can run:
for varying number of
output_dim