Open
Conversation
Balandat
reviewed
Sep 14, 2022
Collaborator
Balandat
left a comment
There was a problem hiding this comment.
There are a number of call sites in gpytorch that @gpleiss or @jacobrgardner have a much better understanding of, so I'll defer to their input on this.
Collaborator
|
As to the changes here, they look good in isolation. |
Member
|
I just want to be careful about making sure these don't get used. The problem these lines of code originally solved is that, with the current lazy kernel evaluation design, ALL covariance matrices are LazyEvaluatedKernelTensors until we evaluate the kernel, so if we need to type check the kind of linear operator we get out of a Kernel call we can't do that until the kernel has been evaluated |
Member
|
It would be great if we could remove this, but I agree with Jake that we want to be extra careful :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at removing
evaluate_kernelfrom thelinear_operatorpackage. This was already suggested in a comment in the code and makes sense since -- as far as I can tell -- it is a no-op for all operators in this package.The main question at this point seems to be if additional changes are required in GPyTorch, which defines
LazyEvaluatedKernelTensorand should therefore take care of any of its implementation specifics.