Adds settings.trace_mode and skip cholesky jitter#27
Merged
gpleiss merged 4 commits intocornellius-gp:mainfrom Nov 8, 2022
Merged
Adds settings.trace_mode and skip cholesky jitter#27gpleiss merged 4 commits intocornellius-gp:mainfrom
gpleiss merged 4 commits intocornellius-gp:mainfrom
Conversation
gpleiss
approved these changes
Oct 22, 2022
Member
|
This makes sense to me! It seems like we'd want a PR in GPyTorch to ensure that |
Contributor
Author
|
Sounds good, I will send a commit for the unit tests soon. |
auto-merge was automatically disabled
October 26, 2022 21:20
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to use gpytorch in our NUTS sampler. While the linked code works, it does not utilize JIT compilation (
use_nnc) because of control flow.I understand
trace_modewas originally used to disable custom pytorch functions back when JIT did not support compiling through them. This PR (along with cornellius-gp/gpytorch#2163) revives the setting for the AoT JIT compiler (https://pytorch.org/functorch/nightly/aot_autograd.html).settings.trace_modefromgpytorchtolinear_operatorstrace_modeis true, currently:linear_operators.utils.choleskyx1_eq_x2check ingpytorch.kernels.kernel