fix broken provisioning#1800
Open
skamensky wants to merge 2 commits into
Open
Conversation
Signed-off-by: skamensky <shmuelkamensky@gmail.com>
Signed-off-by: skamensky <shmuelkamensky@gmail.com>
Member
|
Could you please explain when exactly this failed and why this fixes it? I'd imagine we'd find it long ago if it was a boot level issue 😅 |
|
Stale pull request message |
Member
|
@skamensky Am cleaning up PR's. Is this still relevant? |
Contributor
Author
|
I'm not sure. I'm using a frozen version of corteza at this point. Feel free to close from my POV. There was an actual bug and this is an actual fix. Maybe note that somewhere in case you get a provisioning error in the future to save you the bug hunt. |
Member
|
Okay thanks, will leave it open for now. |
|
Stale pull request message |
Fajfa
force-pushed
the
2023.9.x
branch
2 times, most recently
from
3f44fa3 to
96ef3c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR