Skip to content

fix: Restrict form size validation to non-GET requests #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuelnelson wants to merge 5 commits into
base: 2024.9.x
Choose a base branch
from
Open

fix: Restrict form size validation to non-GET requests #2276

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ebd10b
Restrict form size validation to non-GET requests
manuelnelson Jan 13, 2026
f997368
Merge branch '2024.9.x' into 2024.9.x-fix-oauth-handler
manuelnelson Jan 16, 2026
ce47915
Merge branch '2024.9.x' into 2024.9.x-fix-oauth-handler
manuelnelson Jan 29, 2026
80ceb01
Merge branch '2024.9.x' into 2024.9.x-fix-oauth-handler
manuelnelson Mar 10, 2026
17ea56a
Merge branch '2024.9.x' into 2024.9.x-fix-oauth-handler
manuelnelson Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions server/auth/handlers/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,13 @@ func (h *AuthHandlers) handle(fn handlerFn) http.HandlerFunc {
return
}

if !validFormPost(r) {
req.Status = http.StatusRequestEntityTooLarge
return
// Only validate form post for actual POST/PUT/PATCH requests, not GET
// GET requests with query params (like OIDC callbacks) can have long values
if r.Method == http.MethodPost || r.Method == http.MethodPut || r.Method == http.MethodPatch {
if !validFormPost(r) {
req.Status = http.StatusRequestEntityTooLarge
return
}
}

req.Client = request.GetOauth2Client(req.Session)
Expand Down