Skip to content

Migrate Global blocks branch to latest code#2296

Closed
Toocky wants to merge 6 commits into
cortezaproject:2024.9.xfrom
Toocky:2024.9.x-feature-global-blocks
Closed

Migrate Global blocks branch to latest code#2296
Toocky wants to merge 6 commits into
cortezaproject:2024.9.xfrom
Toocky:2024.9.x-feature-global-blocks

Conversation

@Toocky
Copy link
Copy Markdown

@Toocky Toocky commented Mar 4, 2026

Issue #1598

#1727 PR with the Global blocks feature was previously approved but never merged and is now outdated and was easier to create a new branch and pull the needed code across.

This was not my code.

The following changes are implemented

Global blocks that can be used and updated on any page for example a navigation bar this eliminates the need to create and updated the same navigation block on all pages

Changes in the user interface:

when creating the block there is a new global block switch
image

then when adding blocks to a page there is a global blocks drop down selector at the bottom of the Add Blocks modal
image

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

A side note is there any dev guidance for testing changes? I found the "make watch" to be extremely slow to the point of unusable but I am potentially not doing something correctly.

@Toocky Toocky changed the title Migrate outdated Global blocks branch to latest code, test and resolv… Migrate Global blocks branch to latest code Mar 4, 2026
@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Mar 5, 2026

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1608142 Triggered Generic Password 6b877a5 docker-compose.local.yaml View secret
- - Generic High Entropy Secret 6b877a5 .env.docker.dev View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Toocky Toocky closed this Mar 5, 2026
@Toocky Toocky deleted the 2024.9.x-feature-global-blocks branch March 5, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant