Created Universal Link Input Field type#2305
Open
Toocky wants to merge 10 commits into
Open
Conversation
Author
|
Rebased with 2024.9.8 |
…m/Toocky/corteza into 2024.9.x-feature-link-input-field
…m/Toocky/corteza into 2024.9.x-feature-link-input-field
b8536d1 to
b7d6d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
Created a universal Link field type
#2304
Changes in the user interface:
New Link type selectable from the field type drop down

Defaults to "Dynamic" it will handle web addresses, Emails, and Phone numbers, the URL options are only visible on dynamic and if you have statically selected the URL type.

when you disable the dynamic selection you will be given the preconfigured list of protocols.

if your desired link is not covered you can set a custom protocol.

you can see the dynamic




And statically they will all use the selected protocol without any sanity checks


these could potentially be enhanced to include the other protocols into the dynamic selector if the protocol has a specific ID pattern we can easily map with a regex but for now ive just included email phone and www
Checklist when submitting a final (!draft) PR