Feature - File Uniqueness Checks#2315
Open
Toocky wants to merge 6 commits into
Open
Conversation
e4080de to
8373cbf
Compare
Member
|
@Toocky I would merge this, but for that I'd really like you to clean up the commit history. I would expect one commit per fix/feature. And no merge commits please. Also if you can remove gitignore for claude and your local dev things. |
b8536d1 to
b7d6d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
when uploading a file it would be good to check the file is unique within its own module or within a specific target module
if there is a duplicate detection then allow a choice of options ie alert with link to existing record, or open in modal or new tab or same tab
i used xxhash for its speed and the fact that it was already in the project
#2314
Changes in the user interface:
in the field options you can choose to enforce uniqueness, and choose what you want to happen on conflict
the others are self explanatory the alert appears like this
the other option is you can select a different module to validate uniqueness against
Checklist when submitting a final (!draft) PR