fix(kokoro): handle new {id,name} voices shape from Kokoro-FastAPI v0.4.0#75
Open
remsky wants to merge 1 commit into
Open
fix(kokoro): handle new {id,name} voices shape from Kokoro-FastAPI v0.4.0#75remsky wants to merge 1 commit into
remsky wants to merge 1 commit into
Conversation
Kokoro-FastAPI v0.4.0 (PR #462) changed items in the `voices` array from plain strings to `{"id","name"}` objects. `getVoiceOptions` returned the raw array typed as string[], handing dicts to callers that expect ids. Normalize so easyVoice works against old and new servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heads up: Kokoro-FastAPI v0.4.0 changed the
/v1/audio/voicesresponse shape.Items in the
voicesarray changed from plain strings to{"id","name"}objects (remsky/Kokoro-FastAPI#462).getVoiceOptionsinpackages/backend/src/tts/engines/kokoroTts.ts:99types and returnsstring[], so against v0.4.0 callers receive[{id, name}, ...]typed as strings, which breaks downstream voice pickers.This patch widens the type and normalizes both shapes to a
string[]of ids (filtering empties for safety), keeping the existing contract. Users can also pass?legacy=trueserver-side to keep the old shape if they'd prefer not to update the client.