fix: Improve e2e timeouts#2658
Merged
dianab-cl merged 2 commits intoJun 19, 2026
Merged
Conversation
github-actions
Bot
added
C:Testing
Greptile SummaryThis PR improves e2e CI reliability by adding explicit timeouts to chain-start operations and parallelizing the compatibility-test matrix. Previously a consumer chain that never produced blocks would block indefinitely; now it fails within 5 minutes at the Go level, and the CI job itself is capped at 30 minutes per consumer version.
Confidence Score: 5/5The changes are safe to merge; they tighten timeouts and parallelize CI without altering any production logic. The goroutine + buffered-channel (size 1) + select pattern is correctly implemented in both actions files: the goroutine can always drain without blocking even if the timeout branch fires first, and log.Fatalf exits the process before any leak becomes a concern. The workflow matrix correctly sets fail-fast: false so a hanging version does not cancel siblings, and the reduced per-job timeout (30 min) is generous relative to the stated healthy startup time (under 1 minute). No files require special attention. Important Files Changed
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+213
to
+231
| go func() { | ||
| for scanner.Scan() { | ||
| out := scanner.Text() | ||
| if verbose { | ||
| fmt.Println("startChain: " + out) | ||
| } | ||
| if out == done { | ||
| scanDone <- nil | ||
| return | ||
| } | ||
| } | ||
| if out == done { | ||
| break | ||
| if err := scanner.Err(); err != nil { | ||
| scanDone <- err | ||
| return | ||
| } | ||
| } | ||
| if err := scanner.Err(); err != nil { | ||
| log.Fatal(err) | ||
| // The script exited (stdout closed) before signaling done, which means | ||
| // the chain failed to start rather than just being slow. | ||
| scanDone <- fmt.Errorf("chain %s start script exited before signaling done", action.Chain) | ||
| }() |
Comment on lines
+145
to
+161
| go func() { | ||
| for scanner.Scan() { | ||
| out := scanner.Text() | ||
| if verbose { | ||
| fmt.Println("startChain: " + out) | ||
| } | ||
| if out == done { | ||
| scanDone <- nil | ||
| return | ||
| } | ||
| } | ||
| if out == done { | ||
| break | ||
| if err := scanner.Err(); err != nil { | ||
| scanDone <- err | ||
| return | ||
| } | ||
| } | ||
| if err := scanner.Err(); err != nil { | ||
| log.Fatal(err) | ||
| scanDone <- fmt.Errorf("chain %s start script exited before signaling done", action.Chain) | ||
| }() |
Comment on lines
+845
to
+861
| go func() { | ||
| for scanner.Scan() { | ||
| out := scanner.Text() | ||
| if verbose { | ||
| fmt.Println("assign key - reconfigure: " + out) | ||
| } | ||
| if out == done { | ||
| scanDone <- nil | ||
| return | ||
| } | ||
| } | ||
| if out == done { | ||
| break | ||
| if err := scanner.Err(); err != nil { | ||
| scanDone <- err | ||
| return | ||
| } | ||
| } | ||
| if err := scanner.Err(); err != nil { | ||
| log.Fatal(err) | ||
| scanDone <- fmt.Errorf("reconfigure node for %s exited before signaling done", action.Chain) | ||
| }() |
Eric-Warehime
approved these changes
Jun 19, 2026
| matrix: | ||
| # Consumer versions tested against the latest provider. | ||
| # For new versions to be tested add/remove entries here. | ||
| consumer-version: [latest, v5.2.0, v6.3.0] |
Contributor
There was a problem hiding this comment.
We can probably just test latest. Stride is really the only one we care about right now and they're on v7 That will likely reduce test time even further.
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
dianab-cl
commented
Jun 19, 2026
Contributor
Merge Queue Status
This pull request spent 20 seconds in the queue, including 4 seconds running CI. Waiting for
All conditions
ReasonPull request #2658 has been dequeued merge conditions no longer match. Blocked by:
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Tick the box to put this pull request back in the merge queue (same as
|
35 tasks
dianab-cl
deleted the
diana/fou-251-improve-e2e-pipeline-for-interchain-security
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please go to the
Previewtab and select the appropriate sub-template:fix,feat, andrefactor.