ci: add explicit benchmarks web typecheck - #144
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 1 hour, 37 minutes, and 50 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
b24968b to
d82ff76
Compare
Summary
pnpm typecheckscript for the benchmarks web appValidation
.github/workflows/web-ci.ymlpnpm --dir web install --frozen-lockfileuv --directory runner sync --frozen --devcoval_bench.api.app.create_app()NEXT_PUBLIC_API_URL=http://localhost:8000 pnpm codegenpnpm lintpnpm typecheckpnpm test(32 passed)pnpm buildGreptile Summary
This PR adds an explicit
pnpm typecheckscript (tsc --noEmit) to the benchmarks web app and wires it into the reusable CI workflow as a dedicated step between Lint and Test, with the job name updated to match.web/package.json: Newtypecheckscript usingtsc --noEmit, placed betweenlint:fixandtestin the scripts block..github/workflows/web-ci.yml: New "Typecheck" step inserted after Lint and before Test; jobnameupdated fromCodegen / Lint / Test / BuildtoCodegen / Lint / Typecheck / Test / Build.Confidence Score: 5/5
Safe to merge — the change is additive CI hardening with no risk to application code or existing workflow steps.
Both changes are purely additive: a new tsc --noEmit script and the corresponding CI step inserted at the right point in the pipeline (after codegen generates types, before test and build). The job name was also correctly updated. No application logic is touched.
No files require special attention.
Important Files Changed
Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant GH as GitHub Actions participant Node as Node.js (pnpm) participant UV as uv / Python participant TSC as tsc GH->>Node: pnpm install --frozen-lockfile GH->>UV: uv sync --frozen --dev UV->>UV: Serve OpenAPI schema on :8000 GH->>Node: "pnpm codegen (NEXT_PUBLIC_API_URL=http://localhost:8000)" Note over Node: Generates TypeScript types from OpenAPI GH->>Node: pnpm lint GH->>TSC: pnpm typecheck (tsc --noEmit) Note over TSC: NEW — type-checks generated + app code GH->>Node: pnpm test GH->>Node: pnpm build%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant GH as GitHub Actions participant Node as Node.js (pnpm) participant UV as uv / Python participant TSC as tsc GH->>Node: pnpm install --frozen-lockfile GH->>UV: uv sync --frozen --dev UV->>UV: Serve OpenAPI schema on :8000 GH->>Node: "pnpm codegen (NEXT_PUBLIC_API_URL=http://localhost:8000)" Note over Node: Generates TypeScript types from OpenAPI GH->>Node: pnpm lint GH->>TSC: pnpm typecheck (tsc --noEmit) Note over TSC: NEW — type-checks generated + app code GH->>Node: pnpm test GH->>Node: pnpm buildComments Outside Diff (1)
.github/workflows/web-ci.yml, line 24 (link)namefield still lists the old four phases and doesn't reflect the newly added Typecheck step, which can be confusing when reading workflow run summaries on GitHub.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (2): Last reviewed commit: "ci: add explicit benchmarks web typechec..." | Re-trigger Greptile