Skip to content

ci: add explicit benchmarks web typecheck - #144

Merged
borgesius merged 1 commit into
mainfrom
codex/benchmarks-web-typecheck
Jun 19, 2026
Merged

ci: add explicit benchmarks web typecheck#144
borgesius merged 1 commit into
mainfrom
codex/benchmarks-web-typecheck

Conversation

@borgesius

@borgesius borgesius commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a first-class pnpm typecheck script for the benchmarks web app
  • run it in the reusable web CI adapter after OpenAPI codegen and before tests/build

Validation

  • parsed .github/workflows/web-ci.yml
  • pnpm --dir web install --frozen-lockfile
  • uv --directory runner sync --frozen --dev
  • generated local OpenAPI schema from coval_bench.api.app.create_app()
  • NEXT_PUBLIC_API_URL=http://localhost:8000 pnpm codegen
  • pnpm lint
  • pnpm typecheck
  • pnpm test (32 passed)
  • pnpm build

Greptile Summary

This PR adds an explicit pnpm typecheck script (tsc --noEmit) to the benchmarks web app and wires it into the reusable CI workflow as a dedicated step between Lint and Test, with the job name updated to match.

  • web/package.json: New typecheck script using tsc --noEmit, placed between lint:fix and test in the scripts block.
  • .github/workflows/web-ci.yml: New "Typecheck" step inserted after Lint and before Test; job name updated from Codegen / Lint / Test / Build to Codegen / Lint / Typecheck / Test / Build.

Confidence Score: 5/5

Safe to merge — the change is additive CI hardening with no risk to application code or existing workflow steps.

Both changes are purely additive: a new tsc --noEmit script and the corresponding CI step inserted at the right point in the pipeline (after codegen generates types, before test and build). The job name was also correctly updated. No application logic is touched.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/web-ci.yml Adds a Typecheck step (pnpm typecheck) between Lint and Test; updates job name. Step ordering and placement are correct — codegen runs first so generated types are available for tsc.
web/package.json Adds the typecheck script (tsc --noEmit). Command is idiomatic for Next.js/TypeScript projects; typescript is already in devDependencies.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant GH as GitHub Actions
    participant Node as Node.js (pnpm)
    participant UV as uv / Python
    participant TSC as tsc

    GH->>Node: pnpm install --frozen-lockfile
    GH->>UV: uv sync --frozen --dev
    UV->>UV: Serve OpenAPI schema on :8000
    GH->>Node: "pnpm codegen (NEXT_PUBLIC_API_URL=http://localhost:8000)"
    Note over Node: Generates TypeScript types from OpenAPI
    GH->>Node: pnpm lint
    GH->>TSC: pnpm typecheck (tsc --noEmit)
    Note over TSC: NEW — type-checks generated + app code
    GH->>Node: pnpm test
    GH->>Node: pnpm build
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant GH as GitHub Actions
    participant Node as Node.js (pnpm)
    participant UV as uv / Python
    participant TSC as tsc

    GH->>Node: pnpm install --frozen-lockfile
    GH->>UV: uv sync --frozen --dev
    UV->>UV: Serve OpenAPI schema on :8000
    GH->>Node: "pnpm codegen (NEXT_PUBLIC_API_URL=http://localhost:8000)"
    Note over Node: Generates TypeScript types from OpenAPI
    GH->>Node: pnpm lint
    GH->>TSC: pnpm typecheck (tsc --noEmit)
    Note over TSC: NEW — type-checks generated + app code
    GH->>Node: pnpm test
    GH->>Node: pnpm build
Loading

Comments Outside Diff (1)

  1. .github/workflows/web-ci.yml, line 24 (link)

    P2 The job name field still lists the old four phases and doesn't reflect the newly added Typecheck step, which can be confusing when reading workflow run summaries on GitHub.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (2): Last reviewed commit: "ci: add explicit benchmarks web typechec..." | Re-trigger Greptile

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
benchmarks Ready Ready Preview, Comment Jun 19, 2026 5:10am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@borgesius, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour, 37 minutes, and 50 seconds. Learn how PR review limits work.

To continue reviewing without waiting, enable usage-based billing in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fba02a5c-8ef8-4c1c-b71d-4ac5840ea2eb

📥 Commits

Reviewing files that changed from the base of the PR and between d90a63e and d82ff76.

📒 Files selected for processing (2)
  • .github/workflows/web-ci.yml
  • web/package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/benchmarks-web-typecheck

Comment @coderabbitai help to get the list of available commands and usage tips.

@borgesius
borgesius added this pull request to the merge queue Jun 19, 2026
Merged via the queue into main with commit b96800d Jun 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants