Skip to content

Authenticate the Fluxions websocket - #450

Merged
coval-cale merged 1 commit into
mainfrom
cale/bench-568-authenticate-the-fluxions-websocket
Aug 5, 2026
Merged

Authenticate the Fluxions websocket#450
coval-cale merged 1 commit into
mainfrom
cale/bench-568-authenticate-the-fluxions-websocket

Conversation

@coval-cale

@coval-cale coval-cale commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Add an api key handshake to the fluxions client

Greptile Summary

The PR adds API-key authentication to the Fluxions TTS WebSocket handshake.

  • Adds FLUXIONS_API_KEY to settings, environment documentation, and the provider-key registry.
  • Requires the credential when constructing the Fluxions provider and sends it as a Bearer authorization header.
  • Updates Fluxions tests to cover authenticated handshakes and missing credentials.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code defect established.

The new credential follows the existing settings and provider-key conventions, and the supported WebSocket dependency accepts the authorization-header argument used by the handshake.

Reviews (1): Last reviewed commit: "Authenticate the Fluxions websocket" | Re-trigger Greptile

Context used:

Fluxions bot-gated the keyless VUI socket, so send the API key as a bearer header on the handshake and wire it through Settings, the provider key map, and tests.
@coval-cale
coval-cale requested a review from a team as a code owner August 5, 2026 16:11
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
benchmarks Ready Ready Preview Aug 5, 2026 4:12pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This change adds FLUXIONS_API_KEY to example environment configuration, Settings, and the provider key registry. It updates the Fluxions VUI registry note to state that FLUXIONS_API_KEY is not mounted on benchmarks-api. Fluxions TTS now requires settings.fluxions_api_key, raises ValueError when the key is absent, and sends the key as a bearer Authorization header in the synthesis WebSocket handshake. The tests now set a SecretStr API key, capture WebSocket headers, verify the bearer header, and cover the missing-key error.

Suggested reviewers: cooperr1, seribaymadina

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: Fluxions WebSocket authentication.
Description check ✅ Passed The description directly describes adding API key authentication to the Fluxions client.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread runner/src/coval_bench/providers/tts/fluxions.py
@coval-cale
coval-cale enabled auto-merge August 5, 2026 16:15
@coval-cale
coval-cale added this pull request to the merge queue Aug 5, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.env.example:
- Line 42: Reorder the environment entries in the .env.example block so
FLUXIONS_API_KEY appears before GLADIA_API_KEY, keeping the rest of the variable
order unchanged and aligned with the dotenv-linter expectation.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1652aa37-553b-454d-8589-704d793a3b98

📥 Commits

Reviewing files that changed from the base of the PR and between 8f0a3c8 and e447911.

📒 Files selected for processing (6)
  • .env.example
  • runner/src/coval_bench/config.py
  • runner/src/coval_bench/providers/tts/fluxions.py
  • runner/src/coval_bench/registries/models.py
  • runner/src/coval_bench/registries/provider_keys.py
  • runner/tests/providers/tts/test_fluxions.py

Comment thread .env.example
MINIMAX_API_KEY=
MODULATE_API_KEY=
LMNT_API_KEY=
FLUXIONS_API_KEY=

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Place FLUXIONS_API_KEY before GLADIA_API_KEY.

dotenv-linter reports this key is out of order. Restore the expected order to keep the environment-file lint check passing.

🧰 Tools
🪛 dotenv-linter (4.0.0)

[warning] 42-42: [UnorderedKey] The FLUXIONS_API_KEY key should go before the GLADIA_API_KEY key

(UnorderedKey)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.env.example at line 42, Reorder the environment entries in the .env.example
block so FLUXIONS_API_KEY appears before GLADIA_API_KEY, keeping the rest of the
variable order unchanged and aligned with the dotenv-linter expectation.

Source: Linters/SAST tools

Merged via the queue into main with commit 1fc0a4a Aug 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants