[BENCH-622] Add Deepdub TTS provider - #452
Conversation
Streams dd-etts-3.0 over Deepdub's realtime WebSocket API as an early-access entry with a preset voice pool.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdded Deepdub API-key configuration and provider registry entries. Added Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…epdub-tts-provider # Conflicts: # .env.example # runner/src/coval_bench/config.py # runner/src/coval_bench/registries/provider_keys.py
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@runner/src/coval_bench/providers/tts/deepdub.py`:
- Around line 94-117: Update the send and receive flow in
DeepdubTTSProvider.synthesize so the WebSocket operation is bounded by the
provider’s request timeout, including waiting for each frame until isFinished.
Catch the timeout, then return a failed TTSResult through the existing failure
path instead of waiting indefinitely; preserve normal audio collection and
completion behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6fa4608f-3b62-4cba-ab35-438a759a8220
📒 Files selected for processing (7)
.env.examplerunner/src/coval_bench/config.pyrunner/src/coval_bench/providers/tts/__init__.pyrunner/src/coval_bench/providers/tts/deepdub.pyrunner/src/coval_bench/registries/models.pyrunner/src/coval_bench/registries/provider_keys.pyrunner/tests/providers/tts/test_deepdub.py
A clean WebSocket close without the terminator frame is truncation, not a complete synthesis.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.env.example:
- Line 42: Replace the FLUXIONS_API_KEY entry in the environment template with
DEEPDUB_API_KEY=, matching the configuration and provider-key symbols used by
config.py and provider_keys.py.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 27918c05-db0f-4d7e-b00a-941c68effb7e
📒 Files selected for processing (6)
.env.examplerunner/src/coval_bench/config.pyrunner/src/coval_bench/providers/tts/deepdub.pyrunner/src/coval_bench/registries/models.pyrunner/src/coval_bench/registries/provider_keys.pyrunner/tests/providers/tts/test_deepdub.py
🚧 Files skipped from review as they are similar to previous changes (4)
- runner/src/coval_bench/config.py
- runner/src/coval_bench/registries/provider_keys.py
- runner/src/coval_bench/registries/models.py
- runner/src/coval_bench/providers/tts/deepdub.py
Streams dd-etts-3.0 over Deepdub's realtime WebSocket API as an early-access entry with a preset voice pool.
Greptile Summary
Adds Deepdub's
dd-etts-3.0TTS integration as an early-access model using its realtime WebSocket API.Confidence Score: 4/5
The premature-close path should be fixed before merging because it can silently record truncated Deepdub synthesis as valid benchmark data.
The provider recognizes
isFinishedinside the loop but does not require that signal after iteration ends, while downstream finalization and orchestration treat any nonempty audible PCM without an error as a successful measurement.Files Needing Attention: runner/src/coval_bench/providers/tts/deepdub.py
Reviews (1): Last reviewed commit: "[BENCH-622] Add Deepdub TTS provider" | Re-trigger Greptile
Context used: