Show the inference region only where latency is plotted - #455
Show the inference region only where latency is plotted#455seribaymadina wants to merge 1 commit into
Conversation
The region marker had spread to the WER bar chart and the accuracy scatter, where a network round-trip says nothing about quality. A globe also rode the top of every cross-region WER bar, which read as if it applied to neighbouring models too. It now appears on the timeline tooltip, the latency distribution, and the region filter chips.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (2)
WalkthroughThe PR removes cross-region badges and props from bar and scatter tooltips. It adds cross-region badge support to timeline tooltips and passes the model map through all timeline tooltip instances. Dashboard quality and latency sections remove obsolete region wiring while retaining dedicated-inference indicators. Region facet options now display a globe icon. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| }} | ||
| > | ||
| {provider} | ||
| <RegionBadge region={crossRegionModels?.get(modelName)} /> |
There was a problem hiding this comment.
When a user opens this badge in a non-compact timeline tooltip, its absolutely positioned explanation remains inside the tooltip's overflow-scrolling model list, causing the popover to be clipped or confined to the inner scroll area—especially in the 106px mobile pinned tooltip.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
2 participants
The region marker had spread to the WER bar chart and the accuracy scatter, where a network round-trip says nothing about quality. A globe also rode the top of every cross-region WER bar, reading as if it applied to neighbouring models too.
It now shows on the timeline tooltip, the latency distribution, and the region filter chips.
Fish Audio's three
us-west-1TTS models are the only ones tagged today.Greptile Summary
The PR confines inference-region indicators to latency-related timeline tooltips and region filter chips, removing them from quality charts.
Confidence Score: 4/5
The timeline region badge popover should be moved outside the tooltip's overflow-clipped model list before merging.
The region label renders, but its interactive explanation is mounted beneath an overflow-scrolling ancestor and is especially constrained in the 106px mobile pinned tooltip.
Files Needing Attention: web/components/charts/tooltips/TimelineTooltip.tsx
Reviews (1): Last reviewed commit: "Show the inference region only where lat..." | Re-trigger Greptile