Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/commands/reports.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,10 @@ pub async fn execute(cmd: ReportCommands, client: &CovalClient, ctx: &OutputCont
fn validate_metadata_key(input: &serde_json::Map<String, serde_json::Value>) -> Result<()> {
let is_metadata =
input.get("compare_by").and_then(serde_json::Value::as_str) == Some("metadata");
let has_metadata_key = input.contains_key("metadata_key");
// An explicit null deserializes to None, so it is absent, not supplied.
let has_metadata_key = input
.get("metadata_key")
.is_some_and(|value| !value.is_null());

if is_metadata && !has_metadata_key {
anyhow::bail!("--metadata-key is required when --compare-by is metadata");
Expand Down
40 changes: 40 additions & 0 deletions tests/cli_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3835,6 +3835,46 @@ fn test_reports_create_metadata_key_rejected_without_metadata_compare_by() {
));
}

#[test]
fn test_reports_create_metadata_rejects_null_metadata_key() {
coval()
.arg("--api-key")
.arg("test_key")
.arg("reports")
.arg("create")
.arg("--name")
.arg("Bad Report")
.arg("--run-ids")
.arg("run1")
.arg("--compare-by")
.arg("metadata")
.arg("--input-json")
.arg(r#"{"metadata_key": null}"#)
.assert()
.failure()
.stderr(predicate::str::contains("--metadata-key is required"));
}

#[test]
fn test_reports_create_allows_null_metadata_key_without_metadata_compare_by() {
coval()
.arg("--api-key")
.arg("test_key")
.arg("reports")
.arg("create")
.arg("--name")
.arg("Report")
.arg("--run-ids")
.arg("run1")
.arg("--compare-by")
.arg("run")
.arg("--input-json")
.arg(r#"{"metadata_key": null}"#)
.assert()
.failure()
.stderr(predicate::str::contains("--metadata-key can only be set").not());
}

#[tokio::test]
async fn test_traces_search_sends_structured_filters_and_preserves_cursor() {
let mock_server = MockServer::start().await;
Expand Down
Loading