Skip to content

return metric averages - #12

Closed
rheabryce wants to merge 1 commit into
mainfrom
metric-averages
Closed

return metric averages#12
rheabryce wants to merge 1 commit into
mainfrom
metric-averages

Conversation

@rheabryce

@rheabryce rheabryce commented Jan 6, 2025

Copy link
Copy Markdown

Important

Enhance run_eval.py to return metric averages by updating get_run_status_api and run functions.

  • Behavior:
    • get_run_status_api in run_eval.py now accepts get_metrics parameter to fetch metrics.
    • run in run_eval.py retrieves and returns metric averages after run completion.

This description was created by Ellipsis for d2a374b. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d2a374b in 16 seconds

More details
  • Looked at 39 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. run_eval.py:55
  • Draft comment:
    When get_metrics is True, get_run_status_api should return the full result, not just the 'status'.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_zmZQTWmRyfzUBLGg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants