[COVAL-4344] Add dedicated managed-key credential - #27
Draft
callumreid wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rollout safety
Validation
10 passed158 passedgit diff --check: passedThis is a compatibility change only; deployment and credential activation remain separately controlled.
Independent review fixes (2026-07-31)
Operator documentation now defines the dedicated hosted credential as primary and distinct from the shared fallback, pins immutable secret-version coordination, permits fallback exactly once only after explicit 401 authentication rejection, forbids fallback for timeouts, network failures, 403, and application failures, and documents bounded cutover, drain, removal, rollback, and telemetry expectations.
The full post-change suite remains green at 14 suites and 158 tests.