Skip to content

[IDX-7033] Remove boost::hana in favor of concepts#41

Open
dalloriam wants to merge 3 commits into
feature/IDX-7025-performance-improvementsfrom
feature/IDX-7025-concepts
Open

[IDX-7033] Remove boost::hana in favor of concepts#41
dalloriam wants to merge 3 commits into
feature/IDX-7025-performance-improvementsfrom
feature/IDX-7025-concepts

Conversation

@dalloriam

@dalloriam dalloriam commented May 15, 2026

Copy link
Copy Markdown
Contributor

Changes

  • This PR ditches boost::hana in favor of concepts now that we're > C++20

@dalloriam
dalloriam requested a review from Copilot May 15, 2026 13:24
@dalloriam dalloriam self-assigned this May 15, 2026
@dalloriam dalloriam changed the title [IDX-7025] Use concepts [IDX-7025] Remove boost::hana in favor of concepts May 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces Boost.Hana-based compile-time trait checks with C++ concepts and removes the now-unused Boost.Hana vcpkg dependency.

Changes:

  • Removed boost-hana from vcpkg feature dependencies.
  • Replaced Hana trait utilities with C++ concepts in detail/traits.h.
  • Updated cache event-handler dispatch and collect_into branching to use if constexpr.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
vcpkg.json Removes the boost-hana dependency and reformats the manifest.
include/cachemere/detail/traits.h Replaces Boost.Hana detection traits with C++ concepts.
include/cachemere/cache.h Uses the new concepts for container collection and optional policy event callbacks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/cachemere/cache.h Outdated
Comment thread include/cachemere/cache.h
Comment thread include/cachemere/detail/traits.h
@dalloriam
dalloriam force-pushed the feature/IDX-7025-concepts branch 2 times, most recently from dedc204 to 56b7e9c Compare May 21, 2026 15:05
@dalloriam
dalloriam marked this pull request as ready for review May 21, 2026 15:29
@dalloriam dalloriam changed the title [IDX-7025] Remove boost::hana in favor of concepts [IDX-7033] Remove boost::hana in favor of concepts May 21, 2026
@dalloriam
dalloriam force-pushed the feature/IDX-7025-performance-improvements branch from 91649b0 to f0d0931 Compare May 26, 2026 17:28
@dalloriam
dalloriam force-pushed the feature/IDX-7025-concepts branch from 56b7e9c to 3229d5b Compare May 27, 2026 12:47
@dalloriam
dalloriam requested a review from bourque-julien May 28, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants